Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: The server directory is build by version, and build only when the profile is 'release-seata' #3123

Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Sep 17, 2020

Ⅰ. Describe what this PR did

optimize: The server directory is build by version, and build only when the profile is release-seata.
优化:seata-server的目录按版本号构建,且仅当profilerelease-seata时才构建。

优化后的好处

  1. 按版本号构建目录的好处:在不同版本的分支切换并分别构建seata-server时,不同版本的jar包不会混淆在一个目录中。
  2. profile=release-seata才构建的好处:有时候我们只是想重新打包上传到maven私服,但构建server会因为部分文件被占用,导致构建失败从而影响打包上传。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020

Codecov Report

Merging #3123 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3123      +/-   ##
=============================================
- Coverage      50.58%   50.57%   -0.02%     
+ Complexity      3105     3103       -2     
=============================================
  Files            599      599              
  Lines          19514    19514              
  Branches        2408     2408              
=============================================
- Hits            9871     9869       -2     
  Misses          8651     8651              
- Partials         992      994       +2     
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 82.43% <0.00%> (-0.46%) 70.00% <0.00%> (-1.00%)

@slievrly
Copy link
Member

missing -Dlogback.color.disable-for-bat=true

@wangliang181230
Copy link
Contributor Author

missing -Dlogback.color.disable-for-bat=true

I will merge the develop branch.

…-server-build-target-path

# Conflicts:
#	server/pom.xml
@wangliang181230
Copy link
Contributor Author

missing -Dlogback.color.disable-for-bat=true

done

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #3123 (c8bbecf) into develop (15f0d6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3123   +/-   ##
==========================================
  Coverage      51.12%   51.12%           
  Complexity      3295     3295           
==========================================
  Files            614      614           
  Lines          20125    20125           
  Branches        2514     2514           
==========================================
  Hits           10288    10288           
  Misses          8805     8805           
  Partials        1032     1032           

@slievrly
Copy link
Member

image

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 5fb5b38 into apache:develop Dec 28, 2020
@wangliang181230 wangliang181230 deleted the optimize-server-build-target-path branch December 28, 2020 01:36
@slievrly slievrly added this to the 1.5.0 milestone Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants