-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: The server directory is build by version, and build only when the profile is 'release-seata' #3123
optimize: The server directory is build by version, and build only when the profile is 'release-seata' #3123
Conversation
…en the profile is 'release-seata'
Codecov Report
@@ Coverage Diff @@
## develop #3123 +/- ##
=============================================
- Coverage 50.58% 50.57% -0.02%
+ Complexity 3105 3103 -2
=============================================
Files 599 599
Lines 19514 19514
Branches 2408 2408
=============================================
- Hits 9871 9869 -2
Misses 8651 8651
- Partials 992 994 +2
|
missing |
I will merge the |
…-server-build-target-path # Conflicts: # server/pom.xml
done |
Codecov Report
@@ Coverage Diff @@
## develop #3123 +/- ##
==========================================
Coverage 51.12% 51.12%
Complexity 3295 3295
==========================================
Files 614 614
Lines 20125 20125
Branches 2514 2514
==========================================
Hits 10288 10288
Misses 8805 8805
Partials 1032 1032 |
…-server-build-target-path
…-server-build-target-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize: The server directory is build by version, and build only when the profile is
release-seata
.优化:
seata-server
的目录按版本号构建,且仅当profile
为release-seata
时才构建。优化后的好处
seata-server
时,不同版本的jar包不会混淆在一个目录中。profile=release-seata
才构建的好处:有时候我们只是想重新打包上传到maven私服,但构建server会因为部分文件被占用,导致构建失败从而影响打包上传。Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews