feature: support rollback info compress #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zip(default)和gzip两种压缩方式的压缩比例都挺高的，然后总的压缩+插入时间也比较短 |
|
|
|
good job |
|
ps: 以上测试时间数据都是在MySQL下测试得来，pg和Oracle只是进行了功能测试，没有进行性能测试。 |
|
补一下测试的时候的日志和统计数据。 |
funky-eyes
reviewed
Oct 10, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/undo/oracle/OracleUndoLogManager.java
Outdated
Show resolved
Hide resolved
|
config.txt application.properties application.properties supplement the related configuration |
funky-eyes
reviewed
Oct 10, 2020
...pring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Show resolved
Hide resolved
…roperties template
…o' into feature-add-zip-for-rollback-info
Codecov Report
@@ Coverage Diff @@
## develop #3172 +/- ##
=============================================
- Coverage 51.11% 50.96% -0.15%
+ Complexity 3297 3295 -2
=============================================
Files 614 616 +2
Lines 20125 20180 +55
Branches 2514 2524 +10
=============================================
- Hits 10287 10285 -2
- Misses 8806 8857 +51
- Partials 1032 1038 +6
|
…o' into feature-add-zip-for-rollback-info
jsbxyyx
reviewed
Oct 14, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoLogManager.java
Outdated
Show resolved
Hide resolved
funky-eyes
added
the
type: feature
li-qr
reviewed
Oct 30, 2020
…o' into feature-add-zip-for-rollback-info
# Conflicts: # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java
# Conflicts: # script/client/spring/application.properties # script/client/spring/application.yml # script/config-center/config.txt # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java
jsbxyyx
reviewed
Dec 3, 2020
# Conflicts: # compressor/seata-compressor-all/pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support rollback info compress
支持对undo_log中的rollback_info进行压缩存储
顺便把 OracleUndoLogManager 和 PostgresqlUndoLogManager 中的hard code用常量替换了
Ⅱ. Does this pull request fix one issue?
fixes #3159
Ⅲ. Why don't you add test cases (unit test/integration test)?
already add
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews