optimize: Local variable 'map' is redundant and check queue offer return value #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
theme: wiki-document
funky-eyes
reviewed
Oct 13, 2020
core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java
Show resolved
Hide resolved
| if (basket == null) { | ||
| map.putIfAbsent(serverAddress, new LinkedBlockingQueue<>()); | ||
| basket = map.get(serverAddress); | ||
| basketMap.putIfAbsent(serverAddress, new LinkedBlockingQueue<>()); |
There was a problem hiding this comment.
basketMap.computeIfAbsent(serverAddress, k -> new LinkedBlockingQueue<>());
I think it's better that way. what do you think?
added 2 commits
October 14, 2020 10:32
* origin/develop: optimize: Local variable 'map' is redundant and check queue offer return value apache#3187
Codecov Report
@@ Coverage Diff @@
## develop #3188 +/- ##
=============================================
- Coverage 51.03% 51.03% -0.01%
+ Complexity 3281 3246 -35
=============================================
Files 612 608 -4
Lines 20112 19975 -137
Branches 2517 2495 -22
=============================================
- Hits 10265 10195 -70
+ Misses 8820 8764 -56
+ Partials 1027 1016 -11 |
| map.putIfAbsent(serverAddress, new LinkedBlockingQueue<>()); | ||
| basket = map.get(serverAddress); | ||
| basketMap.computeIfAbsent(serverAddress, k -> new LinkedBlockingQueue<>()); | ||
| if (!basketMap.get(serverAddress).offer(rpcMessage)) { |
There was a problem hiding this comment.
do not need to get again
BlockingQueue<RpcMessage> basket = basketMap.computeIfAbsent(serverAddress, k -> new LinkedBlockingQueue<>());
if (!basket .offer(rpcMessage)) {
......
}
core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 14, 2020 11:02
* origin/develop: optimize: Local variable 'map' is redundant and check queue offer return value apache#3187
* origin/develop:
core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
added 4 commits
October 14, 2020 11:23
* origin/develop:
* origin/develop:
* origin/develop:
* origin/develop:
|
请绑定一下githubid到你本地的git插件上 |
|
解决一下冲突，再绑定一下githubid到你本地的git插件上push一下 |
funky-eyes
changed the title
LiWenGu
pushed a commit
to LiWenGu/seata
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
https://github.com/seata/seata/blob/6c0c75939dedbf19c4a21a8ac7aa0fb98879a8fd/core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java#L156
// put message into basketMap
ConcurrentHashMap<String, BlockingQueue> map = basketMap;
BlockingQueue basket = map.get(serverAddress);
if (basket == null) {
map.putIfAbsent(serverAddress, new LinkedBlockingQueue<>());
basket = map.get(serverAddress);
}
basket.offer(rpcMessage);
1.remove redundant local variable 'map';
2.check the BlockingQueue offer return value;
Ⅱ. Does this pull request fix one issue?
fixes #3187
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews