Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: Local variable 'map' is redundant and check queue offer return value #3188

Merged
merged 20 commits into from
Nov 11, 2020
Merged

optimize: Local variable 'map' is redundant and check queue offer return value #3188

Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8c7e5b6
optimize: remove repeated conditional tests (#3161)
Sep 29, 2020
bc11ac6
optimize: remove repeated conditional tests (#3161)
Sep 29, 2020
c2d1d5c
Merge branch 'develop' into develop
xingfudeshi Oct 1, 2020
340ffbb
Merge branch 'develop' of https://github.com/seata/seata into develop
Oct 13, 2020
e45c5f8
optimize: Local variable 'map' is redundant and check queue offer ret…
Oct 13, 2020
5fd12fe
optimize: Local variable 'map' is redundant and check queue offer ret…
Oct 13, 2020
8256383
Merge remote-tracking branch 'origin/develop' into develop
Oct 14, 2020
17aa810
Merge remote-tracking branch 'origin/develop' into develop
Oct 14, 2020
a90a013
Merge remote-tracking branch 'origin/develop' into develop
Oct 14, 2020
8c8e4ed
Merge remote-tracking branch 'origin/develop' into develop
Oct 14, 2020
b0da324
Merge remote-tracking branch 'origin/develop' into develop
Oct 14, 2020
70902c7
Merge remote-tracking branch 'origin/develop' into develop
Oct 14, 2020
4528430
Merge remote-tracking branch 'origin/develop' into develop
Oct 14, 2020
bee3157
Merge branch 'develop' into develop
everyhook1 Oct 14, 2020
c59eb9b
Merge branch 'develop' into develop
everyhook1 Oct 14, 2020
d6308ca
Merge remote-tracking branch 'origin/develop' into develop
Oct 15, 2020
4220600
Merge branch 'develop' into develop
wangliang181230 Oct 20, 2020
373c47d
Merge branch 'develop' into develop
everyhook1 Oct 20, 2020
2e57d05
Merge branch 'develop' of https://github.com/seata/seata into develop
Oct 21, 2020
6006a9c
Merge branch 'develop' into develop
funky-eyes Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,11 @@ public Object sendSyncRequest(Object msg) throws TimeoutException {
// put message into basketMap
BlockingQueue<RpcMessage> basket = CollectionUtils.computeIfAbsent(basketMap, serverAddress,
key -> new LinkedBlockingQueue<>());
basket.offer(rpcMessage);
if (!basket.offer(rpcMessage)) {
LOGGER.error("put message into basketMap offer failed, serverAddress:{},rpcMessage:{}",
funky-eyes marked this conversation as resolved.
Show resolved Hide resolved
serverAddress, rpcMessage);
return null;
}
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("offer message: {}", rpcMessage.getBody());
}
Expand Down