Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize the reload during startup in file mode #3215

Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Oct 22, 2020

Ⅰ. Describe what this PR did

optimize: opt the reload during startup in file mode.
优化TC的文件模式,在启动过程中重载文件到内存中的操作。

避免因为一些已完成的全局事务数据堆积太多,导致启动过程中内存溢出了。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 added this to the 1.4.0 milestone Oct 22, 2020
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #3215 (cdb9b4f) into develop (23a407e) will decrease coverage by 0.10%.
The diff coverage is 42.22%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3215      +/-   ##
=============================================
- Coverage      51.11%   51.00%   -0.11%     
+ Complexity      3297     3257      -40     
=============================================
  Files            614      609       -5     
  Lines          20125    20044      -81     
  Branches        2514     2507       -7     
=============================================
- Hits           10287    10224      -63     
+ Misses          8806     8798       -8     
+ Partials        1032     1022      -10     
Impacted Files Coverage Δ Complexity Δ
...erver/storage/file/session/FileSessionManager.java 56.93% <42.22%> (-4.74%) 27.00 <3.00> (ø)
.../src/main/java/io/seata/core/rpc/ShutdownHook.java 0.00% <0.00%> (-82.86%) 0.00% <0.00%> (-8.00%)
...c/main/java/io/seata/config/FileConfiguration.java 41.77% <0.00%> (-1.53%) 11.00% <0.00%> (ø%)
...in/java/io/seata/server/session/GlobalSession.java 82.72% <0.00%> (-0.91%) 70.00% <0.00%> (-1.00%)
...ver/storage/db/session/DataBaseSessionManager.java 36.20% <0.00%> (-0.64%) 12.00% <0.00%> (ø%)
...ver/storage/redis/session/RedisSessionManager.java 29.31% <0.00%> (-0.52%) 10.00% <0.00%> (ø%)
.../java/io/seata/core/compressor/CompressorType.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...in/java/io/seata/rm/datasource/sql/struct/Row.java 100.00% <0.00%> (ø) 10.00% <0.00%> (ø%)
...n/java/io/seata/rm/datasource/undo/SQLUndoLog.java 77.77% <0.00%> (ø) 10.00% <0.00%> (ø%)
.../java/io/seata/rm/datasource/sql/struct/Field.java 90.90% <0.00%> (ø) 9.00% <0.00%> (ø%)
... and 21 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 removed this from the 1.4.0 milestone Oct 23, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the module/server server module label Dec 1, 2020
@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Dec 11, 2020
@xingfudeshi xingfudeshi merged commit af103f4 into apache:develop Jan 4, 2021
@wangliang181230 wangliang181230 deleted the optimize-tc-file-mode-reload branch January 14, 2021 06:08
@slievrly slievrly changed the title optimize: opt the reload during startup in file mode optimize: optimize the reload during startup in file mode Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants