Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: seata plugin #3228

Merged
merged 21 commits into from
Feb 18, 2021
Merged

feature: seata plugin #3228

merged 21 commits into from
Feb 18, 2021

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Oct 28, 2020

Ⅰ. Describe what this PR did

feature seata plugin. for example: seata jackson parser oracle.

Ⅱ. Does this pull request fix one issue?

fixes: #2047

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #3228 (0996abd) into develop (e4c0683) will decrease coverage by 0.08%.
The diff coverage is 23.52%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3228      +/-   ##
=============================================
- Coverage      51.68%   51.59%   -0.09%     
- Complexity      3394     3401       +7     
=============================================
  Files            621      621              
  Lines          20589    20655      +66     
  Branches        2564     2580      +16     
=============================================
+ Hits           10641    10657      +16     
- Misses          8886     8933      +47     
- Partials        1062     1065       +3     
Impacted Files Coverage Δ Complexity Δ
...m/datasource/undo/parser/FstSerializerFactory.java 81.81% <0.00%> (-18.19%) 6.00 <0.00> (ø)
...m/datasource/undo/parser/JacksonUndoLogParser.java 62.24% <12.50%> (-9.71%) 8.00 <1.00> (ø)
.../datasource/undo/parser/KryoSerializerFactory.java 46.66% <14.28%> (-4.28%) 8.00 <0.00> (ø)
...ta/rm/datasource/undo/parser/FstUndoLogParser.java 40.90% <29.41%> (-42.43%) 6.00 <3.00> (+2.00) ⬇️
...atasource/undo/parser/ProtostuffUndoLogParser.java 55.71% <30.00%> (-4.29%) 6.00 <2.00> (+1.00) ⬇️
...a/rm/datasource/undo/parser/KryoUndoLogParser.java 53.84% <31.25%> (-37.07%) 6.00 <3.00> (+2.00) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 83.33% <0.00%> (+0.43%) 76.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 53.52% <0.00%> (+0.46%) 29.00% <0.00%> (+1.00%)

@jsbxyyx
Copy link
Member Author

jsbxyyx commented Oct 30, 2020

how to use:

1. cd seata-plugin && mvn clean install -DskipTests
2. add dependency.
<dependency>
    <groupId>io.seata</groupId>
    <artifactId>seata-jackson-parser-oracle</artifactId>
    <scope>system</scope>
    <systemPath>${basedir}/libs/seata-jackson-parser-oracle-1.4.0-SNAPSHOT.jar</systemPath>
    <version>1.4.0-SNAPSHOT</version>
</dependency>

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 22, 2021
@funky-eyes funky-eyes added module/rm-datasource rm-datasource module type: feature Category issues or prs related to feature request. labels Jan 22, 2021

<properties>
<!-- seata plugin version -->
<revision>1.5.0-SNAPSHOT</revision>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this version be consistent with the main version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

<maven-compiler-plugin.version>3.6.0</maven-compiler-plugin.version>

<ojdbc.version>19.3.0.0</ojdbc.version>
<seata.version>1.5.0-SNAPSHOT</seata.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this version be consistent with the main version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version is seata dependency version. must be seata support spi version.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oracle timestamp字段类型seata集成报错
6 participants