-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: seata plugin #3228
feature: seata plugin #3228
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3228 +/- ##
=============================================
- Coverage 51.68% 51.59% -0.09%
- Complexity 3394 3401 +7
=============================================
Files 621 621
Lines 20589 20655 +66
Branches 2564 2580 +16
=============================================
+ Hits 10641 10657 +16
- Misses 8886 8933 +47
- Partials 1062 1065 +3
|
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/JacksonUndoLogParser.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/ProtostuffUndoLogParser.java
Outdated
Show resolved
Hide resolved
how to use:
|
...-jackson-parser-oracle/src/test/java/io/seata/plugin/jackson/parser/oracle/package-info.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/spi/ProtostuffDelegate.java
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/spi/KryoTypeSerializer.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/spi/JacksonSerializer.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/spi/FstSerializer.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/ProtostuffUndoLogParser.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/KryoUndoLogParser.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/JacksonUndoLogParser.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/FstUndoLogParser.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/KryoSerializerFactory.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/ProtostuffUndoLogParser.java
Outdated
Show resolved
Hide resolved
|
||
<properties> | ||
<!-- seata plugin version --> | ||
<revision>1.5.0-SNAPSHOT</revision> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this version be consistent with the main version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
<maven-compiler-plugin.version>3.6.0</maven-compiler-plugin.version> | ||
|
||
<ojdbc.version>19.3.0.0</ojdbc.version> | ||
<seata.version>1.5.0-SNAPSHOT</seata.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this version be consistent with the main version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the version is seata dependency version. must be seata support spi version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
feature seata plugin. for example: seata jackson parser oracle.
Ⅱ. Does this pull request fix one issue?
fixes: #2047
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews