-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize:the property bean may not be initialized while reading config value #3316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #3316 +/- ##
=============================================
+ Coverage 51.56% 51.73% +0.16%
- Complexity 3341 3347 +6
=============================================
Files 616 617 +1
Lines 20243 20254 +11
Branches 2541 2541
=============================================
+ Hits 10439 10478 +39
+ Misses 8752 8724 -28
Partials 1052 1052
|
I think it's better to get the configuration directly from the |
What if the environment variables of Seata conflict with those of other software? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If configuration conflict is considered, all components integrated with |
Ⅰ. Describe what this PR did
The property bean may not be initialized while reading config value,so it will cause timeout problem while connecting registry center.like Consul.This PR did a optimization for the problem.
Ⅱ. Does this pull request fix one issue?
fixes #3006
Ⅲ. Why don't you add test cases (unit test/integration test)?
Unit test provided.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews