Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate: Migrate CI provider from Travis CI to Github Actions. #3343

Merged
merged 8 commits into from
Dec 14, 2020

Conversation

ujjboy
Copy link
Contributor

@ujjboy ujjboy commented Dec 7, 2020

Ⅰ. Describe what this PR did

Migrate CI provider from Travis CI to Github Actions.

ref: https://docs.github.com/cn/free-pro-team@latest/actions/learn-github-actions/migrating-from-travis-ci-to-github-actions

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@caohdgege
Copy link
Contributor

ci的报错修复了,把develop合并到你的分支再推一下?

@ujjboy
Copy link
Contributor Author

ujjboy commented Dec 10, 2020

这两个用例还是错的
io.seata.integration.http.HttpTest#testPostProviderXID
io.seata.core.context.RootContextTest#testBind_And_Unbind

@funky-eyes
Copy link
Contributor

这两个用例还是错的
io.seata.integration.http.HttpTest#testPostProviderXID
io.seata.core.context.RootContextTest#testBind_And_Unbind

#3359
这个pr修掉了#testBind_And_Unbind不通过的bug,testPostProviderXID本地跑没有发现有什么异常

@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #3343 (7fa2673) into develop (23a407e) will decrease coverage by 0.10%.
The diff coverage is 55.88%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3343      +/-   ##
=============================================
- Coverage      51.11%   51.00%   -0.11%     
+ Complexity      3297     3293       -4     
=============================================
  Files            614      614              
  Lines          20125    20133       +8     
  Branches        2514     2519       +5     
=============================================
- Hits           10287    10269      -18     
- Misses          8806     8835      +29     
+ Partials        1032     1029       -3     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/core/context/RootContext.java 47.16% <0.00%> (-3.78%) 18.00 <0.00> (-1.00)
...io/seata/core/rpc/netty/RmNettyRemotingClient.java 39.13% <ø> (ø) 10.00 <0.00> (ø)
...scovery/loadbalance/ConsistentHashLoadBalance.java 89.28% <ø> (ø) 3.00 <0.00> (ø)
.../discovery/loadbalance/LeastActiveLoadBalance.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...eata/discovery/loadbalance/LoadBalanceFactory.java 50.00% <ø> (ø) 1.00 <0.00> (ø)
...seata/discovery/loadbalance/RandomLoadBalance.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...a/discovery/loadbalance/RoundRobinLoadBalance.java 66.66% <ø> (ø) 3.00 <0.00> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 60.46% <0.00%> (-0.48%) 26.00 <0.00> (ø)
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 60.37% <ø> (-0.64%) 11.00 <0.00> (-2.00)
.../seata/rm/datasource/exec/MultiUpdateExecutor.java 76.00% <ø> (-0.32%) 12.00 <0.00> (ø)
... and 17 more

@slievrly slievrly added this to the 1.5.0 milestone Dec 14, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 1f9e7cf into develop Dec 14, 2020
@ujjboy ujjboy deleted the migrate_ci branch December 14, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants