Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: remove unused test case #3359

Merged
merged 2 commits into from
Dec 10, 2020
Merged

optimize: remove unused test case #3359

merged 2 commits into from
Dec 10, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title bugfix: temporarily cancels unwanted test cases bugfix: temporarily cancels unwanted test case Dec 10, 2020
@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 10, 2020
@funky-eyes funky-eyes added the module/test test module label Dec 10, 2020
@funky-eyes funky-eyes mentioned this pull request Dec 10, 2020
Merged
caohdgege
caohdgege approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slievrly
slievrly reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused case.

ujjboy
ujjboy approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wangliang181230
wangliang181230 approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 merged commit 1903ac6 into apache:develop Dec 10, 2020
@slievrly slievrly changed the title bugfix: temporarily cancels unwanted test case optimize: remove unused test case Dec 10, 2020
@slievrly slievrly mentioned this pull request Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjboy ujjboy ujjboy approved these changes

@wangliang181230 wangliang181230 wangliang181230 approved these changes

@caohdgege caohdgege caohdgege approved these changes

@long187 long187 Awaiting requested review from long187

@slievrly slievrly Awaiting requested review from slievrly

Assignees
No one assigned
Labels
module/test test module
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@funky-eyes @ujjboy @wangliang181230 @slievrly @caohdgege