Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize ParameterParserTest test case failed #3365

Merged
merged 1 commit into from
Dec 14, 2020
Merged

optimize: optimize ParameterParserTest test case failed #3365

merged 1 commit into from
Dec 14, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Dec 11, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize ParameterParserTest test case failed

Ⅱ. Does this pull request fix one issue?

fix #3364

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@funky-eyes
Copy link
Contributor

只清除环境变量,并不能让ConfigurationFactory.CURRENT_FILE_INSTANCE进行变化。

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 12, 2020
@funky-eyes funky-eyes added the module/test test module label Dec 12, 2020
Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/test test module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit test case failed.
3 participants