optimize: globalTransactionScanner listener optimize #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When disableGlobalTransaction = true at startup, why don't you need to listen to configuration changes for on disableGlobalTransaction? |
|
@lj2018110133 merge the latest develop branch code. |
Codecov Report
@@ Coverage Diff @@
## develop #3380 +/- ##
=============================================
- Coverage 51.55% 51.55% -0.01%
- Complexity 3342 3344 +2
=============================================
Files 616 616
Lines 20247 20247
Branches 2541 2539 -2
=============================================
- Hits 10439 10438 -1
- Misses 8757 8758 +1
Partials 1051 1051
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
globalTransactionScanner listener optimize
Ⅱ. Does this pull request fix one issue?
fixes #3377
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews