Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize github action #3385

Merged
merged 13 commits into from
Dec 21, 2020
Merged

optimize: optimize github action #3385

merged 13 commits into from
Dec 21, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Dec 17, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

fix #3392

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Dec 20, 2020

Codecov Report

Merging #3385 (da01669) into develop (aeeda42) will increase coverage by 0.18%.
The diff coverage is 78.04%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3385      +/-   ##
=============================================
+ Coverage      51.26%   51.44%   +0.18%     
- Complexity      3318     3328      +10     
=============================================
  Files            616      616              
  Lines          20174    20206      +32     
  Branches        2517     2536      +19     
=============================================
+ Hits           10342    10395      +53     
+ Misses          8795     8766      -29     
- Partials        1037     1045       +8     
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/config/ConfigurationCache.java 66.66% <78.04%> (+21.66%) 11.00 <0.00> (+1.00)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (-0.65%) 28.00% <0.00%> (-1.00%)
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.76% <0.00%> (+1.34%) 5.00% <0.00%> (ø%)
...java/io/seata/config/ConfigurationChangeEvent.java 76.92% <0.00%> (+38.46%) 9.00% <0.00%> (+3.00%)
...in/java/io/seata/config/AbstractConfiguration.java 71.42% <0.00%> (+42.85%) 15.00% <0.00%> (+8.00%)
.../java/io/seata/config/ConfigurationChangeType.java 100.00% <0.00%> (+100.00%) 1.00% <0.00%> (+1.00%)

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github action unit test failed
4 participants