-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix can not get update columns with database name #3402
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3402 +/- ##
=============================================
- Coverage 51.67% 51.67% -0.01%
+ Complexity 3357 3355 -2
=============================================
Files 618 618
Lines 20344 20350 +6
Branches 2543 2547 +4
=============================================
+ Hits 10513 10516 +3
- Misses 8781 8783 +2
- Partials 1050 1051 +1
|
Can my pull request be merged?If not, please fix this bug. |
did Oracle and PostgresQL do actual testing? |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Mysql And Oracle test passed, pgsql do not have this problem. You can remove the code in pgsql or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
buildAfterImageSQL时,如果数据库链接是全称getUpdateColumns获取不到更新字段。
如果数据库链接,如update seata.test.info,其中seata为库名字,test是表名,如果更新语句为: update seata.test set seata.test.info = "test" where seata.test.id = 1,则getUpdateColumns返回值是一个空的list.
支持了更新如果是库名+表名+字段的sql
Ⅱ. Does this pull request fix one issue?
fixes #3395
Ⅲ. Why don't you add test cases (unit test/integration test)?
没有
Ⅳ. Describe how to verify it
1.4.1版本写库名,测试不通过,获取不了更新字段
fixes bug后,测试通过
Ⅴ. Special notes for reviews
没有