feature: add config support for seata server thread pool #3411
Conversation
funky-eyes
added
first-time contributor
|
标题请用英文，可参考其他pr，请pull最新develop的代码并提交 |
lvxianzheng
changed the title
server/src/main/resources/file.conf
Outdated
| @@ -1,4 +1,15 @@ | |||
| ## transaction log store, only used in seata-server | |||
| server { | |||
There was a problem hiding this comment.
I have some question about this pr.
1.The configuration ofNetty we already had the prefix name "transport.xxx.xxx", how about change to transport.xxx.xxx instead of server.xxx.xxx
2.How about move this configuration in the NettyServerConfig.java ?
3.We do not show the configuration of Netty in file.conf. How about remove it and add to
file.conf.example
script/server/file.conf
script/server/file.properties
script/server/file.yml
There was a problem hiding this comment.
1 and 2:
I think the thread pool configurations are related to the server itself instead of transport.
So the server.xxx.xxx is more better than transport.
If the configuration is set for client and server communication, it is better using transport.xxx.xxx
- In fact, I can remove the default value in file.conf.
I put the default value into the file.conf, because it is the responsibility to reminder we can change the value for performance problems.
There was a problem hiding this comment.
Thanks for you replay. For now we already put the config of client in the NettyServerConfig and the server in the NettyServerConfig, and they begin with 'transport.xxx.xxx'. How do you think move the config of server to the NettyServerConfig and let it begin with 'transport.xxx.xxx'. May be you are right and I hope can keep in touch with after this. But for now I think the consistency is more important than the correctness.
There was a problem hiding this comment.
Now I put the configure into NettyServerConfig and change the name from server.xxx.xxx to transport.xxx.xxx
Codecov Report
@@ Coverage Diff @@
## develop #3411 +/- ##
=============================================
- Coverage 51.67% 51.65% -0.03%
+ Complexity 3357 3354 -3
=============================================
Files 618 618
Lines 20344 20355 +11
Branches 2543 2544 +1
=============================================
+ Hits 10513 10514 +1
- Misses 8781 8790 +9
- Partials 1050 1051 +1
|
Ⅰ. Describe what this PR did
新功能:增加seata server thread pool 可配置参数功能
Ⅱ. Does this pull request fix one issue?
增加参数配置，可以性能调优,tcc 模式下，当客户端并发超过50的时候，服务器和客户端都会Hang住，可以扩大此参数暂时解决问题，这是因为2阶段同步提交引起的，改为异步提交可以修复此问题。
Ⅲ. Why don't you add test cases (unit test/integration test)?
集成测试才可以测试
Ⅳ. Describe how to verify it
在file.conf中修改配置，运行性能测试，观察线程数量变化
Ⅴ. Special notes for reviews
无