Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix TM/RM can't start properly #3431

Merged
merged 16 commits into from
Jan 4, 2021
Merged

bugfix:fix TM/RM can't start properly #3431

merged 16 commits into from
Jan 4, 2021

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

fix TM/RM can't start properly

Ⅱ. Does this pull request fix one issue?

fixes #3430

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 1, 2021

Codecov Report

Merging #3431 (4897a52) into develop (274fcd0) will decrease coverage by 0.18%.
The diff coverage is 28.84%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3431      +/-   ##
=============================================
- Coverage      51.67%   51.48%   -0.19%     
+ Complexity      3357     3348       -9     
=============================================
  Files            618      617       -1     
  Lines          20355    20350       -5     
  Branches        2544     2544              
=============================================
- Hits           10518    10477      -41     
- Misses          8789     8821      +32     
- Partials        1048     1052       +4     
Impacted Files Coverage Δ Complexity Δ
...ing/boot/autoconfigure/SeataAutoConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...boot/autoconfigure/properties/SeataProperties.java 45.16% <ø> (-9.68%) 7.00 <0.00> (-2.00)
...re/properties/SpringCloudAlibabaConfiguration.java 66.66% <ø> (ø) 5.00 <0.00> (ø)
...gure/provider/SpringBootConfigurationProvider.java 45.00% <60.86%> (-15.72%) 8.00 <2.00> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (-0.65%) 28.00% <0.00%> (-1.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . please update 'changes' 1.5.0.md

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update 'changes/en-us/1.5.0.md'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: TM/RM获取配置超时,导致无法启动
4 participants