-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix TM/RM can't start properly #3431
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3431 +/- ##
=============================================
- Coverage 51.67% 51.48% -0.19%
+ Complexity 3357 3348 -9
=============================================
Files 618 617 -1
Lines 20355 20350 -5
Branches 2544 2544
=============================================
- Hits 10518 10477 -41
- Misses 8789 8821 +32
- Partials 1048 1052 +4
|
...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM . please update 'changes' 1.5.0.md
...oot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/SeataProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please update 'changes/en-us/1.5.0.md'.
Ⅰ. Describe what this PR did
fix TM/RM can't start properly
Ⅱ. Does this pull request fix one issue?
fixes #3430
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews