optimize: adjust the order of springApplicationContextProvider #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3439 +/- ##
=============================================
- Coverage 51.57% 51.54% -0.04%
+ Complexity 3379 3374 -5
=============================================
Files 618 617 -1
Lines 20441 20438 -3
Branches 2564 2564
=============================================
- Hits 10543 10535 -8
- Misses 8839 8841 +2
- Partials 1059 1062 +3
|
xingfudeshi
reviewed
Jan 6, 2021
| @@ -26,9 +28,12 @@ | |||
| * @author xingfudeshi@gmail.com | |||
| * The type spring application context provider | |||
| */ | |||
| public class SpringApplicationContextProvider implements ApplicationContextAware { | |||
| public class SpringApplicationContextProvider implements ApplicationContextAware, BeanFactoryPostProcessor { | |||
funky-eyes
added
module/seata-spring-boot-starter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cate code
Ⅰ. Describe what this PR did
adjust the order of springApplicationContextProvider so that it can init before the bean of xml.
调整springApplicationContextProvider的顺序以使得他可以在xml的bean之前被调用。同时删除了一些无用的代码
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews