Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: send the seata-server log to logstash or kafka #3443

Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Jan 6, 2021

Ⅰ. Describe what this PR did

feature: send the seata-server log to logstash or kafka.
新功能:将seata-server的日志推送到logstashkafka中,再存入elasticsearch中。(默认情况下,该功能处于关闭状态。需要用户自己修改logback.xml。)

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #3443 (bcad134) into develop (5de6f40) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3443      +/-   ##
=============================================
- Coverage      51.56%   51.55%   -0.02%     
+ Complexity      3367     3366       -1     
=============================================
  Files            617      617              
  Lines          20419    20419              
  Branches        2560     2560              
=============================================
- Hits           10529    10526       -3     
- Misses          8835     8837       +2     
- Partials        1055     1056       +1     
Impacted Files Coverage Δ Complexity Δ
...ing/logback/WhitespaceThrowableProxyConverter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)

@wangliang181230 wangliang181230 changed the title feature: send the seata-server log to logstash feature: add logstash-appender and kafka-appender to logback in the seata-server Jan 6, 2021
@wangliang181230 wangliang181230 changed the title feature: add logstash-appender and kafka-appender to logback in the seata-server feature: send the seata-server log to logstash or kafka Jan 6, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 8, 2021
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/server server module labels Jan 8, 2021
@funky-eyes funky-eyes merged commit aebaaff into apache:develop Jan 8, 2021
@wangliang181230 wangliang181230 deleted the feature/logback-to-logstash branch January 8, 2021 03:01
wangliang181230 added a commit to wangliang181230/seata that referenced this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants