-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: failure to compete for a lock causes the global transaction to exit #3451
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3451 +/- ##
=============================================
- Coverage 51.56% 51.54% -0.02%
+ Complexity 3374 3373 -1
=============================================
Files 617 617
Lines 20438 20445 +7
Branches 2565 2565
=============================================
Hits 10539 10539
- Misses 8839 8845 +6
- Partials 1060 1061 +1
|
fc750b6
to
91bef56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -23,6 +23,7 @@ | |||
- [[#3348](https://github.com/seata/seata/pull/3348)] support redis sentinel mode | |||
- [[#2667](https://github.com/seata/seata/pull/2667)] support password decryption | |||
- [[#3427](https://github.com/seata/seata/pull/3427)] add distributed lock interface | |||
- [[#3443](https://github.com/seata/seata/pull/3443)] send the `seata-server` log to `logstash` or `kafka` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this duplicated?
#3443属于feature,但是他填写到了bugfix,所以在我的pr里,帮他做了更正 @l81893521
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
bugfix
Ⅱ. Does this pull request fix one issue?
fix #3442
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
可以下载该代码,https://github.com/ben905713861/seataTest,去除本地事务注解,并发访问测试
Ⅴ. Special notes for reviews