optimize: String comparison uses equalsIgnoreCase() #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3466 +/- ##
==========================================
Coverage 51.54% 51.54%
Complexity 3376 3376
==========================================
Files 617 617
Lines 20474 20474
Branches 2567 2567
==========================================
Hits 10553 10553
Misses 8861 8861
Partials 1060 1060
|
funky-eyes
reviewed
Jan 16, 2021
| @@ -76,7 +76,7 @@ | |||
| "Failed to commit xa branch of " + connectionProxyXA.xid + ") since " + ex.getMessage(), | |||
| ex); | |||
| // XA End & Rollback | |||
| if (!(ex instanceof SQLException) || AbstractConnectionProxyXA.SQLSTATE_XA_NOT_END != ((SQLException) ex).getSQLState()) { | |||
| if (!(ex instanceof SQLException) || !AbstractConnectionProxyXA.SQLSTATE_XA_NOT_END.equals(((SQLException) ex).getSQLState())) { | |||
|
标题以optimize: 开头,并把pr改动登记到changes文件夹中的2个md |
funky-eyes
added
first-time contributor
github-ganyu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
I optimized some of the code: String comparison uses equalsIgnoreCase()
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews