-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: seata node refresh failure because consul crash #3481
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3481 +/- ##
=============================================
- Coverage 51.57% 51.55% -0.02%
+ Complexity 3379 3375 -4
=============================================
Files 619 619
Lines 20468 20475 +7
Branches 2563 2564 +1
=============================================
Hits 10556 10556
- Misses 8852 8858 +6
- Partials 1060 1061 +1
|
...overy-consul/src/main/java/io/seata/discovery/registry/consul/ConsulRegistryServiceImpl.java
Outdated
Show resolved
Hide resolved
将你的pr登记到changes 文件夹的2个md中 可模仿已经登记的pr来描述,英文版的描述直接写pr标题即可,并把个人githubid登记(已登记可忽略) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xingfudeshi PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
使用 consul 作为注册中心, 当 consul 集群宕机时会导致客户端刷新seata 节点信息失败.
由于在刷新任务中 没有对 consul client 调用捕获异常而导致刷新的任务不会继续进行
Ⅱ. Does this pull request fix one issue?
fixes: #3480
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews