Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: seata node refresh failure because consul crash #3481

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

xyz327
Copy link
Contributor

@xyz327 xyz327 commented Jan 21, 2021

Ⅰ. Describe what this PR did

使用 consul 作为注册中心, 当 consul 集群宕机时会导致客户端刷新seata 节点信息失败.
由于在刷新任务中 没有对 consul client 调用捕获异常而导致刷新的任务不会继续进行

Ⅱ. Does this pull request fix one issue?

fixes: #3480

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #3481 (216334d) into develop (23751d6) will decrease coverage by 0.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3481      +/-   ##
=============================================
- Coverage      51.57%   51.55%   -0.02%     
+ Complexity      3379     3375       -4     
=============================================
  Files            619      619              
  Lines          20468    20475       +7     
  Branches        2563     2564       +1     
=============================================
  Hits           10556    10556              
- Misses          8852     8858       +6     
- Partials        1060     1061       +1     
Impacted Files Coverage Δ Complexity Δ
...ery/registry/consul/ConsulRegistryServiceImpl.java 1.85% <11.11%> (+0.86%) 1.00 <1.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (-0.65%) 28.00% <0.00%> (-1.00%)
.../java/io/seata/server/coordinator/DefaultCore.java 48.19% <0.00%> (-0.61%) 24.00% <0.00%> (-1.00%)
...rage/redis/store/RedisTransactionStoreManager.java 63.92% <0.00%> (-0.46%) 37.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 84.09% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 54.41% <0.00%> (+0.49%) 29.00% <0.00%> (ø%)
...erver/storage/file/session/FileSessionManager.java 51.82% <0.00%> (+2.91%) 26.00% <0.00%> (+1.00%)

@funky-eyes
Copy link
Contributor

将你的pr登记到changes 文件夹的2个md中 可模仿已经登记的pr来描述,英文版的描述直接写pr标题即可,并把个人githubid登记(已登记可忽略)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added first-time contributor first-time contributor module/discovery discovery module labels Jan 22, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 22, 2021
@funky-eyes
Copy link
Contributor

@xingfudeshi PTAL

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/discovery discovery module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consul 宕机导致刷新 seata 节点任务中断
4 participants