-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: remove useless codes in ConfigurationFactory #3485
optimize: remove useless codes in ConfigurationFactory #3485
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3485 +/- ##
==========================================
Coverage 51.58% 51.58%
+ Complexity 3387 3386 -1
==========================================
Files 621 621
Lines 20525 20522 -3
Branches 2559 2559
==========================================
Hits 10587 10587
+ Misses 8877 8873 -4
- Partials 1061 1062 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
删了一段无用的try/catch
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews