Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove useless codes in ConfigurationFactory #3485

Merged
merged 3 commits into from
Jan 24, 2021

Conversation

13414850431
Copy link
Contributor

Ⅰ. Describe what this PR did

删了一段无用的try/catch

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #3485 (270d26f) into develop (cee31fa) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3485   +/-   ##
==========================================
  Coverage      51.58%   51.58%           
+ Complexity      3387     3386    -1     
==========================================
  Files            621      621           
  Lines          20525    20522    -3     
  Branches        2559     2559           
==========================================
  Hits           10587    10587           
+ Misses          8877     8873    -4     
- Partials        1061     1062    +1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/seata/config/ConfigurationFactory.java 59.09% <50.00%> (+1.11%) 10.00 <1.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 52.83% <0.00%> (-0.48%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.63% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) 12.00% <0.00%> (+1.00%)

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the first-time contributor first-time contributor label Jan 23, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants