Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove useless if judgments. #3505

Merged
merged 2 commits into from
Jan 31, 2021
Merged

optimize: remove useless if judgments. #3505

merged 2 commits into from
Jan 31, 2021

Conversation

github-ganyu
Copy link
Contributor

Ⅰ. Describe what this PR did

remove useless if judgments.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 29, 2021

Codecov Report

Merging #3505 (8589611) into develop (5a09c25) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3505   +/-   ##
==========================================
  Coverage      51.60%   51.61%           
- Complexity      3390     3394    +4     
==========================================
  Files            621      621           
  Lines          20529    20528    -1     
  Branches        2559     2557    -2     
==========================================
+ Hits           10594    10595    +1     
- Misses          8873     8874    +1     
+ Partials        1062     1059    -3     
Impacted Files Coverage Δ Complexity Δ
...ta/spring/annotation/GlobalTransactionScanner.java 47.74% <75.00%> (+0.42%) 17.00 <0.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 84.09% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 53.30% <0.00%> (+0.47%) 29.00% <0.00%> (+1.00%)
...torage/file/store/FileTransactionStoreManager.java 57.69% <0.00%> (+0.64%) 29.00% <0.00%> (+1.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 请在changes文件夹中的2个md进行作者和pr信息登记

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 30, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants