Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Saga SpringBeanServiceInvoker support switch json parser #3513

Conversation

long187
Copy link
Contributor

@long187 long187 commented Feb 7, 2021

Ⅰ. Describe what this PR did

Saga SpringBeanService invoker support switch json parser.

It was hard code with Fastjson.

Ⅱ. Does this pull request fix one issue?

#3512

Ⅳ. Describe how to verify it

client {
  rm {
    ...
    sagaJsonParser = jackson
    ...
  }
}

or

<bean id="dbStateMachineConfig" class="io.seata.saga.engine.config.DbStateMachineConfig">
    ....
    <property name="sagaJsonParser" value="jackson"></property>
    ....
</bean>

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #3513 (411f51e) into develop (36ebcb8) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3513      +/-   ##
=============================================
- Coverage      51.96%   51.95%   -0.02%     
  Complexity      3481     3481              
=============================================
  Files            637      637              
  Lines          21054    21065      +11     
  Branches        2605     2610       +5     
=============================================
+ Hits           10941    10944       +3     
- Misses          9032     9038       +6     
- Partials        1081     1083       +2     
Impacted Files Coverage Δ Complexity Δ
.../saga/statelang/parser/impl/JacksonJsonParser.java 46.87% <28.57%> (-4.98%) 5.00 <1.00> (+1.00) ⬇️
...ata/saga/statelang/parser/impl/FastjsonParser.java 43.75% <37.50%> (-6.25%) 5.00 <1.00> (+1.00) ⬇️

@funky-eyes funky-eyes added this to the 1.5.0 milestone Feb 21, 2021
@funky-eyes funky-eyes added mode: SAGA SAGA transaction mode type: optimize labels Feb 21, 2021
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230
Copy link
Contributor

Please modify the 1.5.0.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: SAGA SAGA transaction mode type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants