Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add acl-token for consul #3516

Merged
merged 2 commits into from
Feb 16, 2021
Merged

feature: add acl-token for consul #3516

merged 2 commits into from
Feb 16, 2021

Conversation

StellaiYang
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly
Copy link
Member

slievrly commented Feb 9, 2021

@StellaiYang u need to modify some files at https://github.com/seata/seata/tree/develop/script.

@codecov-io
Copy link

codecov-io commented Feb 10, 2021 •
edited

Codecov Report

Merging #3516 (e03c340) into develop (20e21a1) will decrease coverage by 0.02%.
The diff coverage is 9.09%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3516      +/-   ##
=============================================
- Coverage      51.73%   51.71%   -0.03%     
- Complexity      3399     3400       +1     
=============================================
  Files            621      621              
  Lines          20576    20589      +13     
  Branches        2566     2568       +2     
=============================================
+ Hits           10645    10647       +2     
- Misses          8868     8879      +11     
  Partials        1063     1063
Impacted Files Coverage Δ Complexity Δ
...ery/registry/consul/ConsulRegistryServiceImpl.java 1.76% <0.00%> (-0.09%) 1.00 <0.00> (ø)
...gure/properties/config/ConfigConsulProperties.java 44.44% <25.00%> (-15.56%) 2.00 <0.00> (ø)
.../properties/registry/RegistryConsulProperties.java 46.15% <25.00%> (-9.41%) 3.00 <0.00> (ø)

@StellaiYang StellaiYang changed the title 注册中心与配置中心为consul时添加ACL-Token认证 Add acl-token when registry and configuration center Feb 10, 2021
@StellaiYang StellaiYang changed the title Add acl-token when registry and configuration center Add acl-token when registry and configuration center are consul Feb 10, 2021
@slievrly slievrly changed the title Add acl-token when registry and configuration center are consul feature: add acl-token for consul Feb 10, 2021
@slievrly slievrly added the first-time contributor first-time contributor label Feb 10, 2021
slievrly
slievrly approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xingfudeshi
xingfudeshi approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit e4c0683 into apache:develop Feb 16, 2021
@slievrly slievrly added this to the 1.5.0 milestone Feb 21, 2021
@slievrly slievrly mentioned this pull request Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
first-time contributor first-time contributor
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StellaiYang @slievrly @codecov-io @xingfudeshi