bugfix: fix register branch and flush undolog when affect row was zero #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
funky-eyes
reviewed
Feb 18, 2021
| @@ -279,10 +278,12 @@ protected void prepareUndoLog(TableRecords beforeImage, TableRecords afterImage) | |||
|
|
|||
| TableRecords lockKeyRecords = sqlRecognizer.getSQLType() == SQLType.DELETE ? beforeImage : afterImage; | |||
| String lockKeys = buildLockKey(lockKeyRecords); | |||
| connectionProxy.appendLockKey(lockKeys); | |||
| if (null != lockKeys) { | |||
There was a problem hiding this comment.
maybe you can put it in the connectionProxy# appendLockKey function
There was a problem hiding this comment.
If you put code in connectionProxy# appendLockKey, it will still execute L284~L285.
|
please add test case |
Codecov Report
@@ Coverage Diff @@
## develop #3522 +/- ##
=============================================
+ Coverage 52.15% 52.16% +0.01%
+ Complexity 3510 3508 -2
=============================================
Files 638 638
Lines 21108 21109 +1
Branches 2613 2615 +2
=============================================
+ Hits 11009 11012 +3
+ Misses 9014 9012 -2
Partials 1085 1085
|
funky-eyes
added
module/rm-datasource
lightClouds917
suggested changes
Feb 23, 2021
| @@ -279,10 +278,12 @@ protected void prepareUndoLog(TableRecords beforeImage, TableRecords afterImage) | |||
|
|
|||
| TableRecords lockKeyRecords = sqlRecognizer.getSQLType() == SQLType.DELETE ? beforeImage : afterImage; | |||
| String lockKeys = buildLockKey(lockKeyRecords); | |||
| connectionProxy.appendLockKey(lockKeys); | |||
| if (null != lockKeys) { | |||
There was a problem hiding this comment.
the method return value , is from :
StringBuilder sb = new StringBuilder(); xxx return sb.toString();
It can not use null != lockkeys, should use if(!StringUtils.isBlank(lockKeys))
There was a problem hiding this comment.
if (rowsIncludingPK.size() == 0) {
return null;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: fix register branch and flush undolog when affect row was zero
Ⅱ. Does this pull request fix one issue?
fix #3521
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews