Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the possible NPE #3597

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Mar 26, 2021

Ⅰ. Describe what this PR did

根据FindBugs插件提示,找到的可能会导致NPE的BUG。原代码行172行。
图片

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , pls add change log.

@wangliang181230 wangliang181230 changed the title bugfix: fix the possible NPE. bugfix: fix the possible NPE Mar 26, 2021
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 2dac3a5 into apache:develop Mar 26, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 26, 2021
@funky-eyes funky-eyes added the type: bug Category issues or prs related to bug. label Mar 26, 2021
@wangliang181230 wangliang181230 deleted the bugfix/possible-NPE branch March 30, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants