Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize nacos-config.py parameter #3631

Merged
merged 3 commits into from
Apr 14, 2021
Merged

optimize: optimize nacos-config.py parameter #3631

merged 3 commits into from
Apr 14, 2021

Conversation

nature80
Copy link
Contributor

@nature80 nature80 commented Apr 12, 2021

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix #3630

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.4.2 milestone Apr 12, 2021
@funky-eyes
Copy link
Contributor

changes文件夹中的2个1.5.0的md补充一下pr和登记一下你的个人github信息,标题以optimize: 开头

@funky-eyes
Copy link
Contributor

标题以optimize: 开头

@funky-eyes
Copy link
Contributor

还有md文件里,你的github信息没有登记

@nature80 nature80 changed the title Update nacos-config.py optimize nacos-config.py Apr 13, 2021
@nature80
Copy link
Contributor Author

还有md文件里,你的github信息没有登记

你说的是添加 contributors 部分内容吗?就提交了一个,不好意思加里面。贡献多了,再加

@funky-eyes
Copy link
Contributor

还有md文件里,你的github信息没有登记

你说的是添加 contributors 部分内容吗?就提交了一个,不好意思加里面。贡献多了,再加

只要再当前发行版贡献过任意一个pr被合并都应该被记录,这是你应得的

@funky-eyes funky-eyes changed the title optimize nacos-config.py optimize: nacos-config.py Apr 13, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize: nacos-config.py optimize: optimize nacos-config.py parameter Apr 14, 2021
@slievrly slievrly merged commit 1de031d into apache:develop Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nacos-config.py localhost:8848 报 python nacos-config.py nacosAddr
3 participants