-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize nacos-config.py parameter #3631
Conversation
changes文件夹中的2个1.5.0的md补充一下pr和登记一下你的个人github信息,标题以optimize: 开头 |
标题以optimize: 开头 |
还有md文件里,你的github信息没有登记 |
你说的是添加 contributors 部分内容吗?就提交了一个,不好意思加里面。贡献多了,再加 |
只要再当前发行版贡献过任意一个pr被合并都应该被记录,这是你应得的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fix #3630
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews