-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize the error of join table syntax #3638
optimize: optimize the error of join table syntax #3638
Conversation
Is there nessnary to modify the method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe change it when support join sql. |
Codecov Report
@@ Coverage Diff @@
## develop #3638 +/- ##
=============================================
- Coverage 52.15% 52.06% -0.09%
Complexity 3509 3509
=============================================
Files 638 638
Lines 21109 21146 +37
Branches 2614 2628 +14
=============================================
+ Hits 11009 11010 +1
- Misses 9014 9048 +34
- Partials 1086 1088 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#2442
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews