Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize the error of join table syntax #3638

Merged
merged 5 commits into from
Apr 16, 2021

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

#2442

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@l81893521 l81893521 added this to the 1.4.2 milestone Apr 15, 2021
@l81893521 l81893521 added the module/sqlparser sql-parser module label Apr 15, 2021
@caohdgege
Copy link
Contributor

Is there nessnary to modify the method getTableAlias
plz modify the title.

@l81893521 l81893521 changed the title optimize: optimize the error of join table in update syntax optimize: optimize the error of join table in syntax Apr 15, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521
Copy link
Contributor Author

Is there nessnary to modify the method getTableAlias
plz modify the title.

Maybe change it when support join sql.

@codecov-io
Copy link

codecov-io commented Apr 16, 2021

Codecov Report

Merging #3638 (91c8639) into develop (d8c09ab) will decrease coverage by 0.08%.
The diff coverage is 8.51%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3638      +/-   ##
=============================================
- Coverage      52.15%   52.06%   -0.09%     
  Complexity      3509     3509              
=============================================
  Files            638      638              
  Lines          21109    21146      +37     
  Branches        2614     2628      +14     
=============================================
+ Hits           11009    11010       +1     
- Misses          9014     9048      +34     
- Partials        1086     1088       +2     
Impacted Files Coverage Δ Complexity Δ
...sqlparser/druid/oracle/OracleDeleteRecognizer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...sqlparser/druid/oracle/OracleUpdateRecognizer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...r/druid/postgresql/PostgresqlDeleteRecognizer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...r/druid/postgresql/PostgresqlUpdateRecognizer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/sqlparser/druid/mysql/MySQLDeleteRecognizer.java 66.66% <25.00%> (-14.29%) 8.00 <0.00> (ø)
...a/sqlparser/druid/mysql/MySQLUpdateRecognizer.java 84.00% <28.57%> (-9.34%) 15.00 <0.00> (ø)

@l81893521 l81893521 changed the title optimize: optimize the error of join table in syntax optimize: optimize the error of join table syntax Apr 16, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 23e6119 into apache:develop Apr 16, 2021
@l81893521 l81893521 deleted the optimize_join_table_error_log branch April 22, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants