Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support the registry center network preferences #3886

Merged
merged 14 commits into from
Sep 9, 2021
Merged

feature: support the registry center network preferences #3886

merged 14 commits into from
Sep 9, 2021

Conversation

slievrly
Copy link
Member

Ⅰ. Describe what this PR did

feature: support the registry center network preferences

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #3886 (e3bb653) into develop (f028831) will increase coverage by 0.04%.
The diff coverage is 25.45%.

❗ Current head e3bb653 differs from pull request most recent head b7036e1. Consider uploading reports for the commit b7036e1 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3886      +/-   ##
=============================================
+ Coverage      49.34%   49.38%   +0.04%     
- Complexity      3721     3726       +5     
=============================================
  Files            692      692              
  Lines          23419    23431      +12     
  Branches        2902     2910       +8     
=============================================
+ Hits           11555    11571      +16     
+ Misses         10701    10695       -6     
- Partials        1163     1165       +2     
Impacted Files Coverage Δ
...source/exec/mysql/MySQLInsertOrUpdateExecutor.java 31.07% <ø> (-0.39%) ⬇️
...urce/exec/postgresql/PostgresqlInsertExecutor.java 43.75% <0.00%> (ø)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 66.90% <0.00%> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 0.00% <ø> (ø)
...figure/properties/registry/RegistryProperties.java 37.50% <0.00%> (-22.50%) ⬇️
.../src/main/java/io/seata/server/env/PortHelper.java 0.00% <0.00%> (ø)
server/src/main/java/io/seata/server/Server.java 75.00% <33.33%> (-5.00%) ⬇️
...on/src/main/java/io/seata/common/util/NetUtil.java 65.85% <44.44%> (+13.95%) ⬆️
.../rm/datasource/exec/mysql/MySQLInsertExecutor.java 69.41% <100.00%> (ø)
...m/datasource/exec/oracle/OracleInsertExecutor.java 62.50% <100.00%> (ø)
... and 3 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 话说要不要;和,都适配一下

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jul 22, 2021
@funky-eyes funky-eyes added module/server server module type: feature Category issues or prs related to feature request. labels Jul 22, 2021
@lj2018110133
Copy link
Contributor

LGTM

funky-eyes and others added 2 commits August 31, 2021 16:18
Signed-off-by: slievrly <slievrly@163.com>
@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2021

This pull request fixes 1 alert when merging fc7501c into f028831 - view on LGTM.com

fixed alerts:

  • 1 for Container contents are never accessed

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2021

This pull request fixes 10 alerts when merging e3bb653 into f028831 - view on LGTM.com

fixed alerts:

  • 3 for Boxed variable is never null
  • 2 for Useless null check
  • 2 for Potential input resource leak
  • 1 for Container contents are never accessed
  • 1 for Missing space in string literal
  • 1 for Failure to use HTTPS or SFTP URL in Maven artifact upload/download

Signed-off-by: slievrly <slievrly@163.com>
@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2021

This pull request fixes 15 alerts when merging b7036e1 into f028831 - view on LGTM.com

fixed alerts:

  • 4 for Boxed variable is never null
  • 2 for Container contents are never accessed
  • 2 for Useless null check
  • 2 for Potential input resource leak
  • 1 for Building a command line with string concatenation
  • 1 for Synchronization on boxed types or strings
  • 1 for Missing space in string literal
  • 1 for Failure to use HTTPS or SFTP URL in Maven artifact upload/download
  • 1 for Race condition in double-checked locking object initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants