optimize: simplify if else judgment #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can the DatabaseTransactionStoreManager be optimize like this? |
|
slievrly
added
first-time contributor
l81893521
reviewed
Aug 17, 2021
ok，i finished it |
Codecov Report
@@ Coverage Diff @@
## develop #3939 +/- ##
=============================================
- Coverage 49.59% 40.35% -9.24%
+ Complexity 3730 3072 -658
=============================================
Files 693 685 -8
Lines 23402 23203 -199
Branches 2899 2864 -35
=============================================
- Hits 11606 9364 -2242
- Misses 10631 12969 +2338
+ Partials 1165 870 -295
|
l81893521
reviewed
Aug 17, 2021
drgnchan
reviewed
Aug 18, 2021
Comment on lines
+154
to
+157
| if (globalMap.containsKey(logOperation) || branchMap.containsKey(logOperation)) { | ||
| return globalMap.containsKey(logOperation) ? | ||
| globalMap.get(logOperation).apply(SessionConverter.convertGlobalTransactionDO(session)) : | ||
| branchMap.get(logOperation).apply(SessionConverter.convertBranchTransactionDO(session)); |
There was a problem hiding this comment.
In my opinion,there is no need to invoke globalMap.containsKey(logOperation) again.it is better to break the if statement into two if statements.
|
This pull request introduces 2 alerts when merging 9e03023 into 129c2f3 - view on LGTM.com new alerts:
|
slievrly
changed the title
UmmizzZ
pushed a commit
to UmmizzZ/seata
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
use two ImmutableMap instead of lots of if else judge, and the code is more readability,more convenient to modify.
Ⅱ. Does this pull request fix one issue?
切换develop分支 以及将map并入构造器 旧pr #3932
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews