Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize file configuration #4017

Merged
merged 2 commits into from
Sep 14, 2021
Merged

optimize: optimize file configuration #4017

merged 2 commits into from
Sep 14, 2021

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 14, 2021

Signed-off-by: slievrly slievrly@163.com

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize: optimize file configuration

fix #4015

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #4017 (3c70a0f) into develop (0d2862e) will increase coverage by 0.10%.
The diff coverage is 25.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4017      +/-   ##
=============================================
+ Coverage      49.47%   49.58%   +0.10%     
- Complexity      3729     3730       +1     
=============================================
  Files            692      693       +1     
  Lines          23408    23401       -7     
  Branches        2902     2899       -3     
=============================================
+ Hits           11582    11603      +21     
+ Misses         10666    10632      -34     
- Partials        1160     1166       +6     
Impacted Files Coverage Δ
...ain/java/io/seata/config/ConfigurationFactory.java 59.09% <0.00%> (ø)
...seata/discovery/registry/FileRegistryProvider.java 0.00% <0.00%> (ø)
...a/io/seata/discovery/registry/RegistryFactory.java 0.00% <0.00%> (ø)
...c/main/java/io/seata/config/FileConfiguration.java 47.09% <28.57%> (+1.02%) ⬆️
...seata/server/storage/redis/JedisPooledFactory.java 26.08% <50.00%> (+4.81%) ⬆️
.../src/main/java/io/seata/server/env/PortHelper.java 26.31% <0.00%> (+26.31%) ⬆️

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request fixes 3 alerts when merging 6df150d into ed408db - view on LGTM.com

fixed alerts:

  • 3 for Race condition in double-checked locking object initialization

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @xingfudeshi PTAL

@funky-eyes funky-eyes added this to the 1.5.0 milestone Sep 14, 2021
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request fixes 3 alerts when merging 66a7f7f into 0d2862e - view on LGTM.com

fixed alerts:

  • 3 for Race condition in double-checked locking object initialization

Signed-off-by: slievrly <slievrly@163.com>

# Conflicts:
#	changes/1.5.0.md
#	changes/en-us/1.5.0.md
@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request fixes 3 alerts when merging 3c70a0f into 0d2862e - view on LGTM.com

fixed alerts:

  • 3 for Race condition in double-checked locking object initialization

@slievrly slievrly merged commit 3295003 into apache:develop Sep 14, 2021
UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Signed-off-by: slievrly <slievrly@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong configuration file log printing
4 participants