Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize Nacos, Consul, Zookeeper and Etcd3 configuration #4021

Merged
merged 4 commits into from
Sep 17, 2021
Merged

optimize: optimize Nacos, Consul, Zookeeper and Etcd3 configuration #4021

merged 4 commits into from
Sep 17, 2021

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 15, 2021

Signed-off-by: slievrly slievrly@163.com

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize configuration center

Ⅱ. Does this pull request fix one issue?

fix #4019

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly changed the title optimize: optimize configuration center optimize: optimize Nacos、Consul、Zookeeper and Etcd3 configuration Sep 15, 2021
@slievrly slievrly changed the title optimize: optimize Nacos、Consul、Zookeeper and Etcd3 configuration optimize: optimize Nacos, Consul, Zookeeper and Etcd3 configuration Sep 15, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2021

This pull request fixes 2 alerts when merging 404de57 into 33edf34 - view on LGTM.com

fixed alerts:

  • 2 for Spurious Javadoc @param tags

Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #4021 (4cd31b3) into develop (33edf34) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4021      +/-   ##
=============================================
+ Coverage      49.81%   49.95%   +0.13%     
- Complexity      3760     3773      +13     
=============================================
  Files            698      698              
  Lines          23495    23490       -5     
  Branches        2908     2907       -1     
=============================================
+ Hits           11705    11734      +29     
+ Misses         10609    10576      -33     
+ Partials        1181     1180       -1     
Impacted Files Coverage Δ
...gure/properties/config/ConfigApolloProperties.java 72.72% <ø> (-1.19%) ⬇️
...gure/properties/config/ConfigConsulProperties.java 75.00% <ø> (+36.53%) ⬆️
...igure/properties/config/ConfigEtcd3Properties.java 75.00% <ø> (+30.55%) ⬆️
...igure/properties/config/ConfigNacosProperties.java 75.00% <ø> (+39.00%) ⬆️
...e/properties/config/ConfigZooKeeperProperties.java 75.00% <ø> (+35.00%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 65.00% <ø> (ø)
...gure/provider/SpringBootConfigurationProvider.java 45.00% <0.00%> (+3.33%) ⬆️
...figure/properties/config/ConfigFileProperties.java 80.00% <0.00%> (+20.00%) ⬆️
...gure/properties/config/ConfigCustomProperties.java 80.00% <0.00%> (+20.00%) ⬆️
... and 4 more

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2021

This pull request fixes 2 alerts when merging 4cd31b3 into 33edf34 - view on LGTM.com

fixed alerts:

  • 2 for Spurious Javadoc @param tags

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit b71ba74 into apache:develop Sep 17, 2021
Configuration and registry center related optimizations automation moved this from In progress to Done Sep 17, 2021
@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Configuration and registry center related optimizations
4 participants