Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix potential database resource leak #4025

Merged
merged 3 commits into from
Sep 27, 2021
Merged

bugfix: fix potential database resource leak #4025

merged 3 commits into from
Sep 27, 2021

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 17, 2021

Signed-off-by: slievrly slievrly@163.com

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

bugfix: fix potential database resource leak

Ⅱ. Does this pull request fix one issue?

fix #4024

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #4025 (fa8eed4) into develop (8456fb6) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4025   +/-   ##
==========================================
  Coverage      49.91%   49.92%           
+ Complexity      3767     3766    -1     
==========================================
  Files            698      698           
  Lines          23509    23515    +6     
  Branches        2910     2910           
==========================================
+ Hits           11735    11739    +4     
- Misses         10593    10594    +1     
- Partials        1181     1182    +1     
Impacted Files Coverage Δ
...ommon/loader/EnhancedServiceNotFoundException.java 27.27% <ø> (ø)
...ery/registry/consul/ConsulRegistryServiceImpl.java 1.70% <0.00%> (ø)
...scovery/loadbalance/ConsistentHashLoadBalance.java 89.28% <ø> (ø)
...o/seata/integration/http/AbstractHttpExecutor.java 64.15% <ø> (ø)
...o/seata/rm/datasource/exec/BaseInsertExecutor.java 71.12% <ø> (ø)
...tatelang/parser/utils/DesignerJsonTransformer.java 54.65% <0.00%> (ø)
...java/io/seata/tm/api/DefaultGlobalTransaction.java 65.09% <ø> (ø)
...source/exec/mysql/MySQLInsertOrUpdateExecutor.java 31.42% <50.00%> (ø)
.../rm/datasource/exec/mysql/MySQLInsertExecutor.java 70.00% <71.42%> (+0.58%) ⬆️
...seata/rm/datasource/undo/AbstractUndoExecutor.java 67.14% <100.00%> (+0.23%) ⬆️
... and 1 more

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request fixes 5 alerts when merging 511bde7 into b71ba74 - view on LGTM.com

fixed alerts:

  • 2 for Potential database resource leak
  • 2 for Dereferenced variable may be null
  • 1 for Non-synchronized override of synchronized method

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Sep 26, 2021

This pull request fixes 5 alerts when merging fa8eed4 into 8456fb6 - view on LGTM.com

fixed alerts:

  • 2 for Potential database resource leak
  • 2 for Dereferenced variable may be null
  • 1 for Non-synchronized override of synchronized method

@funky-eyes funky-eyes added this to the 1.5.0 milestone Sep 27, 2021
@funky-eyes funky-eyes added module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug. labels Sep 27, 2021
@funky-eyes funky-eyes merged commit 1a62ada into apache:develop Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential database resource leak
3 participants