feature: init the console basic code #4134

lightClouds917 · 2021-11-12T12:20:40Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

feature:init the console basic code

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

server/src/main/java/io/seata/server/console/manager/BranchSessionServiceManager.java

server/src/main/java/io/seata/server/console/impl/db/GlobalSessionDBServiceImpl.java

server/src/main/java/io/seata/server/console/impl/redis/GlobalSessionRedisServiceImpl.java

server/src/main/java/io/seata/server/console/result/Result.java

server/src/main/java/io/seata/server/console/service/GlobalSessionService.java

lgtm-com · 2021-11-30T02:29:11Z

This pull request introduces 7 alerts when merging 4a76e86 into 87d773f - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

lgtm-com · 2021-12-03T06:59:00Z

This pull request introduces 7 alerts when merging 096c141 into 57789c2 - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

lgtm-com · 2021-12-03T07:49:37Z

This pull request introduces 7 alerts when merging 30f0511 into 57789c2 - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

lgtm-com · 2021-12-03T08:35:09Z

This pull request introduces 7 alerts when merging 89570e9 into 57789c2 - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

lgtm-com · 2021-12-03T10:24:21Z

This pull request introduces 7 alerts when merging 8dc0aba into 57789c2 - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

codecov-commenter · 2021-12-04T13:51:32Z

Codecov Report

Merging #4134 (ca0c274) into develop (a3f8dce) will decrease coverage by 0.26%.
The diff coverage is 4.16%.

@@              Coverage Diff              @@
##             develop    #4134      +/-   ##
=============================================
- Coverage      49.37%   49.11%   -0.27%     
- Complexity      3763     3775      +12     
=============================================
  Files            700      718      +18     
  Lines          23664    23927     +263     
  Branches        2925     2925              
=============================================
+ Hits           11685    11752      +67     
- Misses         10780    10973     +193     
- Partials        1199     1202       +3

Impacted Files	Coverage Δ
...ava/io/seata/core/constants/ConfigurationKeys.java	`0.00% <ø> (ø)`
...a/core/store/db/sql/lock/AbstractLockStoreSql.java	`80.00% <0.00%> (-8.89%)`	⬇️
...ta/core/store/db/sql/log/AbstractLogStoreSqls.java	`91.66% <0.00%> (-8.34%)`	⬇️
...ava/io/seata/core/store/db/vo/BranchSessionVO.java	`0.00% <0.00%> (ø)`
...n/java/io/seata/core/store/db/vo/GlobalLockVO.java	`0.00% <0.00%> (ø)`
...ava/io/seata/core/store/db/vo/GlobalSessionVO.java	`0.00% <0.00%> (ø)`
...er/console/impl/db/BranchSessionDBServiceImpl.java	`0.00% <0.00%> (ø)`
...erver/console/impl/db/GlobalLockDBServiceImpl.java	`0.00% <0.00%> (ø)`
...er/console/impl/db/GlobalSessionDBServiceImpl.java	`0.00% <0.00%> (ø)`
...sole/impl/redis/BranchSessionRedisServiceImpl.java	`0.00% <0.00%> (ø)`
... and 24 more

lgtm-com · 2021-12-04T14:39:33Z

This pull request introduces 7 alerts when merging d5c2653 into 57789c2 - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

lightClouds917 · 2021-12-06T14:32:24Z

控制台基础代码pr概览：
主要是mvc结构，本pr主要是提供基础的框架，未做过多的具体接口实现：
1.db,redis,file三种模式下的branchSession,globalSession,lock的controller，service和serviceImpl框架；
2.2个具体的接口jdbc原生方式实现样例；
3.单个返回对象和分页列表返回对象统一包装类的基础代码实现；
4.bean选择使用springboot的@ConditionalOnExpression(SPEL)的简单方式，支持多个条件生效；
5.2中具体实现接口的sql；
6.上次会议中确定的6个基础的接口预留；
7.返回的实体类对象及转化方法；

server/src/main/java/io/seata/server/console/controller/BranchSessionController.java

server/src/main/java/io/seata/server/console/controller/GlobalLockController.java

server/src/main/java/io/seata/server/console/controller/GlobalSessionController.java

server/src/main/java/io/seata/server/console/impl/db/BranchSessionDBServiceImpl.java

server/src/main/java/io/seata/server/console/impl/db/GlobalLockDBServiceImpl.java

server/src/main/java/io/seata/server/console/impl/db/GlobalSessionDBServiceImpl.java

server/src/main/java/io/seata/server/console/impl/redis/BranchSessionRedisServiceImpl.java

server/src/main/java/io/seata/server/console/impl/redis/GlobalLockRedisServiceImpl.java

lgtm-com · 2021-12-06T15:08:25Z

This pull request introduces 7 alerts when merging ab22d50 into 0a3b496 - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

lgtm-com · 2021-12-07T15:30:34Z

This pull request introduces 7 alerts when merging f6a13bd into 0a3b496 - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

lgtm-com · 2021-12-08T06:05:39Z

This pull request introduces 7 alerts when merging d28810f into a3f8dce - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

server/src/main/java/io/seata/server/ServerApplicationListener.java

server/src/main/java/io/seata/server/console/impl/db/BranchSessionDBServiceImpl.java

server/src/main/java/io/seata/server/console/impl/db/GlobalLockDBServiceImpl.java

lgtm-com · 2021-12-09T10:20:26Z

This pull request introduces 7 alerts when merging 9be069d into a3f8dce - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

lgtm-com · 2021-12-09T11:21:36Z

This pull request introduces 7 alerts when merging ac8aa69 into a3f8dce - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

funky-eyes

LGTM

lgtm-com · 2021-12-09T12:22:26Z

This pull request introduces 7 alerts when merging ca0c274 into a3f8dce - view on LGTM.com

new alerts:

7 for Query built from user-controlled sources

Pinocchio2018 · 2021-12-16T10:50:45Z

server/src/main/java/io/seata/server/ServerApplicationListener.java

@@ -94,6 +96,12 @@ public void onApplicationEvent(ApplicationEvent event) {
        }
        String servicePort = String.valueOf(Integer.parseInt(serverPort) + SERVICE_OFFSET_SPRING_BOOT);
        setTargetPort(environment, servicePort, true);
+
+        // Load by priority
+        System.setProperty("sessionMode",


if I config service-port , this line will not execute

server: service-port: 8091

lightClouds917 added 3 commits November 12, 2021 18:31

feature:init the console

05bdb79

del:del the no use code

f640f0a

optimize:the code format

3ebb36d

funky-eyes reviewed Nov 12, 2021

View reviewed changes

server/src/main/java/io/seata/server/console/manager/BranchSessionServiceManager.java Outdated Show resolved Hide resolved

funky-eyes requested changes Nov 12, 2021

View reviewed changes

del:no use import

ea2ba5e

slievrly added the module/console label Nov 18, 2021

slievrly added this to the 1.5.0 milestone Nov 18, 2021

slievrly and others added 2 commits November 29, 2021 22:31

Merge branch 'develop' into feature_console_basic_interface

af43bfb

update:update the basic interface

8901d5f

lightClouds917 changed the title ~~feature:init the console basic code~~ 【WIP】feature:init the console basic code Nov 30, 2021

lightClouds917 changed the title ~~【WIP】feature:init the console basic code~~ [WIP]feature:init the console basic code Nov 30, 2021

formatl:format the code

4a76e86

update：控制台部分spi修改为springboot方式加载配置和实现

096c141

update：添加按类型引入bean

30f0511

update：调整代码位置

89570e9

merge:from develop

8dc0aba

lightClouds917 added 3 commits December 4, 2021 21:08

add:添加mode=file实现类

2de07a4

format the code

7e71621

revert:还原配置文件

0eccf1a

update:优化protect-->private

d5c2653

lightClouds917 changed the title ~~[WIP]feature:init the console basic code~~ feature:init the console basic code Dec 5, 2021

lightClouds917 changed the title ~~feature:init the console basic code~~ feature: init the console basic code Dec 5, 2021

lightClouds917 added 2 commits December 6, 2021 22:14

update：优化bean加载的spel表达式

5e400f2

update：优化bean加载的spel表达式顺序

d9f4f3c

lightClouds917 added 2 commits December 6, 2021 22:35

merge

35500d5

update:readme.md

ab22d50

funky-eyes added module/server server module type: feature Category issues or prs related to feature request. labels Dec 6, 2021

funky-eyes reviewed Dec 6, 2021

View reviewed changes

update:修改bean加载时条件的判断和注入方式

f6a13bd

lightClouds917 added 2 commits December 8, 2021 13:37

update：优化bean加载的@value使用spel表达式

c379e49

update：修改接口路径

d28810f

funky-eyes reviewed Dec 9, 2021

View reviewed changes

update:sessionMode，lockMode环境变量到系统变量

9be069d

update:spel环境变量取值方式修改

ac8aa69

funky-eyes approved these changes Dec 9, 2021

View reviewed changes

Merge branch 'develop' into feature_console_basic_interface

ca0c274

funky-eyes merged commit 4e2b199 into apache:develop Dec 13, 2021

Pinocchio2018 reviewed Dec 16, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: init the console basic code #4134

feature: init the console basic code #4134

lightClouds917 commented Nov 12, 2021

lgtm-com bot commented Nov 30, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

codecov-commenter commented Dec 4, 2021 •

edited

lgtm-com bot commented Dec 4, 2021

lightClouds917 commented Dec 6, 2021 •

edited

lgtm-com bot commented Dec 6, 2021

lgtm-com bot commented Dec 7, 2021

lgtm-com bot commented Dec 8, 2021

lgtm-com bot commented Dec 9, 2021

lgtm-com bot commented Dec 9, 2021

funky-eyes left a comment

lgtm-com bot commented Dec 9, 2021

Pinocchio2018 Dec 16, 2021

feature: init the console basic code #4134

feature: init the console basic code #4134

Conversation

lightClouds917 commented Nov 12, 2021

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

lgtm-com bot commented Nov 30, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

lgtm-com bot commented Dec 3, 2021

codecov-commenter commented Dec 4, 2021 • edited

Codecov Report

lgtm-com bot commented Dec 4, 2021

lightClouds917 commented Dec 6, 2021 • edited

lgtm-com bot commented Dec 6, 2021

lgtm-com bot commented Dec 7, 2021

lgtm-com bot commented Dec 8, 2021

lgtm-com bot commented Dec 9, 2021

lgtm-com bot commented Dec 9, 2021

funky-eyes left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Dec 9, 2021

Pinocchio2018 Dec 16, 2021

Choose a reason for hiding this comment

codecov-commenter commented Dec 4, 2021 •

edited

lightClouds917 commented Dec 6, 2021 •

edited