-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: simplify the interface of console #4212
optimize: simplify the interface of console #4212
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4212 +/- ##
=============================================
- Coverage 49.03% 48.98% -0.06%
+ Complexity 3783 3782 -1
=============================================
Files 720 723 +3
Lines 24031 24062 +31
Branches 2930 2931 +1
=============================================
+ Hits 11783 11786 +3
- Misses 11038 11067 +29
+ Partials 1210 1209 -1
|
This pull request fixes 7 alerts when merging 9d7a43b into 8590bbf - view on LGTM.com fixed alerts:
|
This pull request fixes 7 alerts when merging 77bb26b into 8590bbf - view on LGTM.com fixed alerts:
|
改动点: |
This pull request fixes 7 alerts when merging 1414c75 into 24e38be - view on LGTM.com fixed alerts:
|
This pull request fixes 7 alerts when merging 970ae90 into 24e38be - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request fixes 7 alerts when merging 3b50104 into 14907c2 - view on LGTM.com fixed alerts:
|
server/src/main/java/io/seata/server/console/impl/db/GlobalLockDBServiceImpl.java
Show resolved
Hide resolved
server/src/main/java/io/seata/server/console/impl/db/GlobalLockDBServiceImpl.java
Outdated
Show resolved
Hide resolved
This pull request fixes 7 alerts when merging dc6a02f into 14907c2 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request fixes 7 alerts when merging eb4f301 into 758642c - view on LGTM.com fixed alerts:
|
resultSet = ps.executeQuery(); | ||
try (Connection conn = dataSource.getConnection(); | ||
PreparedStatement ps = conn.prepareStatement(queryAllBranchSessionSQL); | ||
ResultSet resultSet = ps.executeQuery()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rs not close.
Ⅰ. Describe what this PR did
简化控制台接口数量,提高拓展性:
1.控制台接口合并,使用对象作为入参;
2.防止查询条件变更时,要增加接口提供拓展;
老接口:
新接口:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews