Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: optimize partial code handling #4251

Merged
merged 1 commit into from
Jan 3, 2022
Merged

optimize: optimize partial code handling #4251

merged 1 commit into from
Jan 3, 2022

Conversation

pengten
Copy link
Contributor

@pengten pengten commented Dec 31, 2021 •
edited

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

improve code quality

Ⅱ. Does this pull request fix one issue?

fixes #3690

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

this is my first pull request，please

@funky-eyes funky-eyes changed the title Optimize: improve code quality optimize: improve code quality Jan 1, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 1, 2022
@funky-eyes funky-eyes added module/seata-spring-boot-starter seata-spring-boot-starter module type: optimize module/server server module and removed module/seata-spring-boot-starter seata-spring-boot-starter module labels Jan 1, 2022
@pengten pengten force-pushed the develop branch 2 times, most recently from 7e33ad6 to 5f38a7d Compare January 1, 2022 06:46
@pengten
Copy link
Contributor Author

pengten commented Jan 1, 2022

@a364176773 you are right! I have fixed it, please review again.

funky-eyes
funky-eyes approved these changes Jan 1, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please register your personal and pr information in these two files
https://github.com/seata/seata/blob/develop/changes/1.5.0.md
https://github.com/seata/seata/blob/develop/changes/en-us/1.5.0.md

@funky-eyes
Copy link
Contributor

It would be more appropriate to change the title to 'optimize partial code handling'

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2022 •
edited

Codecov Report

Merging #4251 (b2350ff) into develop (b03abc8) will decrease coverage by 0.00%.
The diff coverage is 11.11%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4251      +/-   ##
=============================================
- Coverage      48.87%   48.87%   -0.01%     
+ Complexity      3799     3797       -2     
=============================================
  Files            724      724              
  Lines          24203    24201       -2     
  Branches        2957     2958       +1     
=============================================
- Hits           11829    11828       -1     
+ Misses         11150    11149       -1     
  Partials        1224     1224
Impacted Files Coverage Δ
...re/properties/SpringCloudAlibabaConfiguration.java 45.45% <ø> (-4.55%) ⬇️
...gure/provider/SpringBootConfigurationProvider.java 45.76% <0.00%> (+0.76%) ⬆️
...o/seata/server/session/AbstractSessionManager.java 56.92% <0.00%> (ø)
...in/java/io/seata/server/transaction/at/ATCore.java 43.33% <0.00%> (ø)
...java/io/seata/server/lock/AbstractLockManager.java 64.06% <100.00%> (ø)

@pengten pengten changed the title optimize: improve code quality optimize: optimize partial code handling Jan 1, 2022
@pengten
Copy link
Contributor Author

pengten commented Jan 1, 2022

It would be more appropriate to change the title to 'optimize partial code handling'
done

@funky-eyes
Copy link
Contributor

发现你本地的git没有绑定你现在的github邮箱,绑定一下,再提交一次,否则你的改动可能不会被正确记录

@pengten
Copy link
Contributor Author

pengten commented Jan 1, 2022

发现你本地的git没有绑定你现在的github邮箱,绑定一下,再提交一次,否则你的改动可能不会被正确记录

Thanks for reminding, i have corrected.

caohdgege
caohdgege approved these changes Jan 1, 2022
View reviewed changes
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...main/java/io/seata/spring/boot/autoconfigure/properties/SpringCloudAlibabaConfiguration.java Outdated Show resolved Hide resolved
@funky-eyes funky-eyes merged commit 631ed7f into apache:develop Jan 3, 2022
slievrly
slievrly reviewed Jan 4, 2022
View reviewed changes
...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
@@ -60,7 +60,7 @@ public Object intercept(Object proxy, Method method, Object[] args, MethodProxy
} else if (args.length == 2) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

args.length > 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it in the next PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it in the next PR

#4262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@funky-eyes funky-eyes funky-eyes approved these changes

@caohdgege caohdgege caohdgege approved these changes

Assignees
No one assigned
Labels
module/server server module type: optimize
Projects
None yet
Milestone
1.5.0 (1.5.1)
Development

Successfully merging this pull request may close these issues.

Optimize Request: Improve code quality.（提升代码质量请求）
5 participants
@pengten @funky-eyes @codecov-commenter @slievrly @caohdgege