Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize tcc module code handling #4262

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

pengten
Copy link
Contributor

@pengten pengten commented Jan 4, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize tcc module code handling

Ⅱ. Does this pull request fix one issue?

fixes #3690

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 changed the title [optimize]:optimize tcc module code handling optimize: optimize tcc module code handling Jan 4, 2022
@wangliang181230
Copy link
Contributor

多余的import移除一下。
图片

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #4262 (79a4f39) into develop (631ed7f) will increase coverage by 0.00%.
The diff coverage is 26.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4262   +/-   ##
==========================================
  Coverage      48.87%   48.87%           
+ Complexity      3799     3797    -2     
==========================================
  Files            724      724           
  Lines          24201    24196    -5     
  Branches        2957     2954    -3     
==========================================
- Hits           11828    11827    -1     
+ Misses         11149    11147    -2     
+ Partials        1224     1222    -2     
Impacted Files Coverage Δ
...gure/provider/SpringBootConfigurationProvider.java 48.21% <ø> (+2.45%) ⬆️
...src/main/java/io/seata/rm/tcc/TCCFenceHandler.java 0.00% <0.00%> (ø)
.../main/java/io/seata/rm/tcc/TCCResourceManager.java 0.00% <0.00%> (ø)
...ava/io/seata/rm/tcc/constant/TCCFenceConstant.java 0.00% <0.00%> (ø)
...o/seata/rm/tcc/store/db/sql/TCCFenceStoreSqls.java 0.00% <0.00%> (ø)
...rm/tcc/remoting/parser/LocalTCCRemotingParser.java 57.69% <55.55%> (+6.07%) ⬆️

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 29578f2 into apache:develop Jan 5, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize Request: Improve code quality.(提升代码质量请求)
5 participants