Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature：Realize the interface of console get global session in the file mode #4268

Merged
merged 37 commits into from
Jan 22, 2022
Merged

feature：Realize the interface of console get global session in the file mode #4268

merged 37 commits into from
Jan 22, 2022

Conversation

miaoxueyu
Copy link
Contributor

@miaoxueyu miaoxueyu commented Jan 6, 2022 •
edited

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

query global session in the file mode

Ⅱ. Does this pull request fix one issue?

fixes #4259

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lgtm-com
Copy link

lgtm-com bot commented Jan 6, 2022

This pull request introduces 6 alerts when merging 3f9a0a7 into 7b11cb5 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 6, 2022
@funky-eyes funky-eyes added first-time contributor first-time contributor module/server server module type: feature Category issues or prs related to feature request. labels Jan 6, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 6, 2022

This pull request introduces 6 alerts when merging efdbd3f into 7b11cb5 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@lightClouds917
Copy link
Contributor

add change log of .md

@lightClouds917
Copy link
Contributor

please add test case

@miaoxueyu
Copy link
Contributor Author

all right

@lgtm-com
Copy link

lgtm-com bot commented Jan 7, 2022

This pull request introduces 6 alerts when merging 9dd8870 into 7c9a875 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2022

This pull request introduces 6 alerts when merging 7e89c2d into 6fa8e91 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@miaoxueyu miaoxueyu changed the title feature：Realize the interface of console: get global session in the file mode [WIP] feature：Realize the interface of console: get global session in the file mode Jan 9, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2022

This pull request introduces 6 alerts when merging 63f490c into 6fa8e91 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2022

This pull request introduces 6 alerts when merging 689de59 into 6fa8e91 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@miaoxueyu
optimized
6b6a4e6
@miaoxueyu
Merge remote-tracking branch 'origin/develop' into develop
a05b227 
# Conflicts:
#	server/src/main/java/io/seata/server/console/impl/file/GlobalSessionFileServiceImpl.java
@lgtm-com
Copy link

lgtm-com bot commented Jan 15, 2022

This pull request introduces 6 alerts when merging a05b227 into d6efb49 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2022 •
edited

Codecov Report

Merging #4268 (ac135e7) into develop (8563bf5) will decrease coverage by 0.03%.
The diff coverage is 41.22%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4268      +/-   ##
=============================================
- Coverage      48.53%   48.50%   -0.04%     
- Complexity      3800     3822      +22     
=============================================
  Files            725      726       +1     
  Lines          24310    24419     +109     
  Branches        2986     3008      +22     
=============================================
+ Hits           11800    11844      +44     
- Misses         11260    11321      +61     
- Partials        1250     1254       +4
Impacted Files Coverage Δ
.../seata/common/exception/InvalidParamException.java 0.00% <0.00%> (ø)
.../java/io/seata/core/console/result/PageResult.java 0.00% <0.00%> (ø)
...java/io/seata/core/console/vo/BranchSessionVO.java 0.00% <0.00%> (ø)
...java/io/seata/core/console/vo/GlobalSessionVO.java 0.00% <0.00%> (ø)
...erver/console/controller/GlobalLockController.java 50.00% <0.00%> (ø)
...er/console/controller/GlobalSessionController.java 50.00% <0.00%> (ø)
...onsole/impl/file/GlobalSessionFileServiceImpl.java 83.33% <82.35%> (+33.33%) ⬆️
...java/io/seata/server/storage/SessionConverter.java 96.62% <100.00%> (+1.98%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
... and 1 more

Pinocchio2018
Pinocchio2018 reviewed Jan 17, 2022
View reviewed changes
changes/1.5.0.md Outdated Show resolved Hide resolved
@funky-eyes funky-eyes changed the title feature：Realize the interface of console: get global session in the file mode feature：Realize the interface of console get global session in the file mode Jan 17, 2022
funky-eyes
funky-eyes approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2022

This pull request introduces 6 alerts when merging 4fad9c3 into 11d3478 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2022

This pull request introduces 6 alerts when merging 5e1bcb2 into 11d3478 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@lgtm-com
Copy link

lgtm-com bot commented Jan 18, 2022

This pull request introduces 6 alerts when merging 2faeada into 11d3478 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2022

This pull request introduces 6 alerts when merging 0eb91fb into 2c6e647 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

lightClouds917
lightClouds917 approved these changes Jan 22, 2022
View reviewed changes
Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Jan 22, 2022

This pull request introduces 6 alerts when merging ac135e7 into 8563bf5 - view on LGTM.com

new alerts:

  • 6 for Query built from user-controlled sources

@lightClouds917 lightClouds917 merged commit 1f3bcc5 into apache:develop Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@Pinocchio2018 Pinocchio2018 Pinocchio2018 left review comments

@GoodBoyCoder GoodBoyCoder GoodBoyCoder left review comments

@funky-eyes funky-eyes funky-eyes approved these changes

@lightClouds917 lightClouds917 lightClouds917 approved these changes

Assignees
No one assigned
Labels
first-time contributor first-time contributor module/server server module type: feature Category issues or prs related to feature request.
Projects
None yet
Milestone
1.5.0 (1.5.1)
Development

Successfully merging this pull request may close these issues.

[Feature]: Realize the interface of console: get global session in the file mode
9 participants
@miaoxueyu @lightClouds917 @codecov-commenter @slievrly @funky-eyes @Pinocchio2018 @GoodBoyCoder @chiangcho @objcoding