-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimization after a unique index conflict occurs in tcc fence log #4303
optimize: optimization after a unique index conflict occurs in tcc fence log #4303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @wangliang181230 PTAL
Codecov Report
@@ Coverage Diff @@
## develop #4303 +/- ##
=============================================
- Coverage 48.59% 48.51% -0.08%
Complexity 3865 3865
=============================================
Files 733 733
Lines 24756 24795 +39
Branches 3052 3054 +2
=============================================
Hits 12030 12030
- Misses 11450 11489 +39
Partials 1276 1276
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经有定时任务删除了,我感觉异步删除没太大必要。
定时任务是兜底作用,在原则上,这个fence记录起到作用后就应该被删除 |
请修改下 1.5.0.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
顺便改一下:
里的默认值 |
收到,下班回去修改md和配置 |
This pull request introduces 1 alert and fixes 6 when merging 8576dbf0c028eafe80da22696d713f72dd1a8752 into d87e8c9 - view on LGTM.com new alerts:
fixed alerts:
|
8576dbf
to
534ae68
Compare
已提交,麻烦帮忙确认下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
TCC 悬挂日志异步删除
Ⅱ. Does this pull request fix one issue?
fixes #3160
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews