feature: Realize the interface of console: get global session and global lock in the db mode #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.readme.md添加一下pr记录； |
lvekee
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4320 +/- ##
=============================================
- Coverage 48.44% 48.27% -0.18%
- Complexity 3965 3969 +4
=============================================
Files 733 734 +1
Lines 25163 25277 +114
Branches 3086 3105 +19
=============================================
+ Hits 12191 12202 +11
- Misses 11658 11760 +102
- Partials 1314 1315 +1
|
# Conflicts: # changes/en-us/1.5.0.md
# Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md # server/src/main/java/io/seata/server/console/controller/GlobalLockController.java # server/src/main/java/io/seata/server/console/controller/GlobalSessionController.java
lvekee
changed the title
|
This pull request fixes 6 alerts when merging 2f127c6 into 3993984 - view on LGTM.com fixed alerts:
|
Bughue
reviewed
Feb 11, 2022
server/src/main/java/io/seata/server/console/impl/db/BranchSessionDBServiceImpl.java
Outdated
Show resolved
Hide resolved
Bughue
reviewed
Feb 11, 2022
| default: | ||
| throw new NotSupportYetException("PageUtil not support this dbType:" + dbType); | ||
| } | ||
| } |
There was a problem hiding this comment.
这个抽一下是不是好点
public static final List<String> SUPPORT_DB = Arrays.asList("mysql", "h2","postgresql","oceanbase","oracle");
public static String countSql(String sourceSql, String dbType) {
if(SUPPORT_DB.contains(dbType)){
return sourceSql.replaceAll("(?i)(?<=select)(.*)(?=from)", " count(1) ");
}else {
throw new NotSupportYetException("PageUtil not support this dbType:" + dbType);
}
}
Bughue
reviewed
Feb 11, 2022
server/src/main/java/io/seata/server/console/controller/GlobalSessionController.java
Show resolved
Hide resolved
Bughue
reviewed
Feb 11, 2022
Bughue
reviewed
Feb 11, 2022
| */ | ||
| public static final String XID_PLACEHOLD = " #xid# "; | ||
| public static final String WHERE_PLACEHOLD = " #where# "; |
There was a problem hiding this comment.
这些place hold要不要抽个类出来？现在已经有两个类都有 #where# 了
Bughue
reviewed
Feb 11, 2022
server/src/main/java/io/seata/server/console/impl/db/GlobalSessionDBServiceImpl.java
Outdated
Show resolved
Hide resolved
# Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md # server/src/main/java/io/seata/server/console/controller/GlobalLockController.java # server/src/main/java/io/seata/server/console/controller/GlobalSessionController.java
|
This pull request fixes 6 alerts when merging 9b560f5 into ca8ff3f - view on LGTM.com fixed alerts:
|
lightClouds917
approved these changes
Feb 23, 2022
server/src/main/java/io/seata/server/console/impl/db/GlobalLockDBServiceImpl.java
Show resolved
Hide resolved
lightClouds917
suggested changes
Feb 25, 2022
server/src/main/java/io/seata/server/console/impl/db/BranchSessionDBServiceImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/console/impl/db/GlobalSessionDBServiceImpl.java
Outdated
Show resolved
Hide resolved
|
lock和session里有部分代码可以公用，是否可以考虑抽取一下。 |
# Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md # core/src/main/java/io/seata/core/console/result/PageResult.java
|
This pull request fixes 6 alerts when merging 06f4344 into 4622746 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 6 alerts when merging eff45fd into 4622746 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 6 alerts when merging a226d1e into 4622746 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 6 alerts when merging 20b4de8 into 16f0bfa - view on LGTM.com fixed alerts:
|
lightClouds917
approved these changes
Mar 4, 2022
server/src/main/java/io/seata/server/console/impl/db/GlobalLockDBServiceImpl.java
Outdated
Show resolved
Hide resolved
# Conflicts: # changes/en-us/1.5.0.md
|
This pull request fixes 6 alerts when merging 23ae12c into 4c88984 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 6 alerts when merging d3eb970 into 6fab0e8 - view on LGTM.com fixed alerts:
|
liuqiufeng
pushed a commit
to liuqiufeng/seata
that referenced
this pull request
Mar 6, 2022
…bal lock in the db mode (apache#4320)
slievrly
reviewed
Mar 11, 2022
| */ | ||
| public static String pageSql(String sourceSql, String dbType, int pageNum, int pageSize) { | ||
| switch (dbType) { | ||
| case "mysql": |
There was a problem hiding this comment.
io.seata.core.constants.DBType
slievrly
reviewed
Mar 11, 2022
| * @return the string | ||
| */ | ||
| String getAllLockSQL(String lockTable, String tableName); | ||
| String getAllLockSql(String lockTable, String whereCondition); |
There was a problem hiding this comment.
Non compliance with design principles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Realize the interface of console: get global session and global lock in the db mode
Ⅱ. Does this pull request fix one issue?
fixes #4256.
fixes #4257.