-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: implementation of DefaultAuthSigner #4480
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4480 +/- ##
=============================================
+ Coverage 48.94% 48.97% +0.02%
+ Complexity 4031 4030 -1
=============================================
Files 730 731 +1
Lines 25309 25323 +14
Branches 3136 3137 +1
=============================================
+ Hits 12387 12401 +14
+ Misses 11602 11594 -8
- Partials 1320 1328 +8
|
This pull request introduces 1 alert when merging 76eab70 into ac12355 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 33d2784 into ac12355 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging fe2a3f1 into 262b26b - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces 1 alert when merging c01bfa2 into e365ea4 - view on LGTM.com new alerts:
|
Ⅰ. Describe what this PR did
实现DefaultAuthSigner的默认签名加密方法,使用的是HmacSHA1加密算法。以及NettyClientChannelManager在进行tm注册的时候,会将最新的时间戳及签名发往服务端。
implement default encrypting method of DefaultAuthSigner by using HmacSHA1. and make sure that tm resgister request sent by client has the latest signature and timestamp.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews