Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: implementation of DefaultAuthSigner #4480

Merged
merged 6 commits into from
Mar 19, 2022
Merged

feature: implementation of DefaultAuthSigner #4480

merged 6 commits into from
Mar 19, 2022

Conversation

onlinechild
Copy link
Contributor

@onlinechild onlinechild commented Mar 18, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

实现DefaultAuthSigner的默认签名加密方法,使用的是HmacSHA1加密算法。以及NettyClientChannelManager在进行tm注册的时候,会将最新的时间戳及签名发往服务端。
implement default encrypting method of DefaultAuthSigner by using HmacSHA1. and make sure that tm resgister request sent by client has the latest signature and timestamp.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #4480 (fe2a3f1) into develop (262b26b) will increase coverage by 0.02%.
The diff coverage is 5.55%.

❗ Current head fe2a3f1 differs from pull request most recent head c01bfa2. Consider uploading reports for the commit c01bfa2 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4480      +/-   ##
=============================================
+ Coverage      48.94%   48.97%   +0.02%     
+ Complexity      4031     4030       -1     
=============================================
  Files            730      731       +1     
  Lines          25309    25323      +14     
  Branches        3136     3137       +1     
=============================================
+ Hits           12387    12401      +14     
+ Misses         11602    11594       -8     
- Partials        1320     1328       +8     
Impacted Files Coverage Δ
...ain/java/io/seata/core/auth/DefaultAuthSigner.java 25.00% <0.00%> (-25.00%) ⬇️
...c/main/java/io/seata/core/auth/RamSignAdapter.java 0.00% <0.00%> (ø)
...eata/core/rpc/netty/NettyClientChannelManager.java 65.41% <16.66%> (-1.00%) ⬇️
...erver/storage/file/session/FileSessionManager.java 52.28% <0.00%> (-1.97%) ⬇️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 30.64% <0.00%> (-1.62%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 56.11% <0.00%> (+5.39%) ⬆️
...er/src/main/java/io/seata/server/ServerRunner.java 65.38% <0.00%> (+15.38%) ⬆️

@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2022

This pull request introduces 1 alert when merging 76eab70 into ac12355 - view on LGTM.com

new alerts:

  • 1 for Use of a broken or risky cryptographic algorithm

@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2022

This pull request introduces 1 alert when merging 33d2784 into ac12355 - view on LGTM.com

new alerts:

  • 1 for Use of a broken or risky cryptographic algorithm

@slievrly slievrly added this to the 1.5.0 milestone Mar 19, 2022
@lgtm-com
Copy link

lgtm-com bot commented Mar 19, 2022

This pull request introduces 1 alert when merging fe2a3f1 into 262b26b - view on LGTM.com

new alerts:

  • 1 for Use of a broken or risky cryptographic algorithm

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 99fc37d into apache:develop Mar 19, 2022
@lgtm-com
Copy link

lgtm-com bot commented Mar 19, 2022

This pull request introduces 1 alert when merging c01bfa2 into e365ea4 - view on LGTM.com

new alerts:

  • 1 for Use of a broken or risky cryptographic algorithm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants