Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix jackson dependencies in TransactionContextFilterTest #4544

Merged
merged 5 commits into from Jun 14, 2022

Conversation

robynron
Copy link
Contributor

@robynron robynron commented Apr 11, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

优化了测试用例TransactionContextFilterTest中jackson包依赖

Ⅱ. Does this pull request fix one issue?

fixes #4540

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added first-time contributor first-time contributor module/integration integration module module/test test module type: optimize labels Apr 11, 2022
@funky-eyes funky-eyes added this to the 2.0.0 milestone Apr 11, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请将pr登记到2.0.0.md中

@funky-eyes funky-eyes changed the base branch from develop to 2.0.0 April 12, 2022 02:48
@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2022

This pull request introduces 1 alert and fixes 6 when merging e1eb9c4 into 4c88984 - view on LGTM.com

new alerts:

  • 1 for Use of a broken or risky cryptographic algorithm

fixed alerts:

  • 6 for Query built from user-controlled sources

@funky-eyes funky-eyes changed the base branch from 2.0.0 to develop April 12, 2022 05:50
@codecov-commenter
Copy link

Codecov Report

Merging #4544 (e1eb9c4) into develop (53d65bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4544   +/-   ##
==========================================
  Coverage      49.35%   49.35%           
  Complexity      4073     4073           
==========================================
  Files            731      731           
  Lines          25465    25465           
  Branches        3156     3156           
==========================================
  Hits           12569    12569           
+ Misses         11559    11558    -1     
- Partials        1337     1338    +1     
Impacted Files Coverage Δ
...erver/storage/file/session/FileSessionManager.java 49.01% <0.00%> (-0.66%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly modified the milestones: 2.0.0, 1.5.2 Jun 6, 2022
@slievrly
Copy link
Member

slievrly commented Jun 6, 2022

@robynron Pls resolve the conflicts.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 120a940 into apache:develop Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/integration integration module module/test test module type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are some UT failed in TransactionContextFilterTest
4 participants