Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: use HmacSHA256 instead of HmacSHA1 for ram signature #4583

Merged
merged 2 commits into from
May 5, 2022

Conversation

onlinechild
Copy link
Contributor

@onlinechild onlinechild commented May 5, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

use HmacSHA256 instead of HmacSHA1 for ram signature

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lgtm-com
Copy link

lgtm-com bot commented May 5, 2022

This pull request fixes 1 alert when merging 14d0412 into 8c350b0 - view on LGTM.com

fixed alerts:

  • 1 for Use of a broken or risky cryptographic algorithm

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

slievrly commented May 5, 2022

image

@codecov-commenter
Copy link

Codecov Report

Merging #4583 (df2088d) into develop (a05e5d9) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4583      +/-   ##
=============================================
- Coverage      49.45%   49.23%   -0.22%     
+ Complexity      4071     4056      -15     
=============================================
  Files            732      733       +1     
  Lines          25521    25561      +40     
  Branches        3153     3153              
=============================================
- Hits           12621    12586      -35     
- Misses         11554    11633      +79     
+ Partials        1346     1342       -4     
Impacted Files Coverage Δ
...e/src/main/java/io/seata/core/auth/AuthSigner.java 0.00% <0.00%> (ø)
...ain/java/io/seata/core/auth/DefaultAuthSigner.java 20.00% <0.00%> (-5.00%) ⬇️
...c/main/java/io/seata/core/auth/RamSignAdapter.java 0.00% <0.00%> (ø)
...java/io/seata/core/protocol/RegisterTMRequest.java 42.85% <ø> (ø)
...io/seata/core/rpc/netty/TmNettyRemotingClient.java 55.55% <0.00%> (-0.63%) ⬇️
...source/exec/mysql/MySQLInsertOrUpdateExecutor.java 31.07% <0.00%> (ø)
...boot/autoconfigure/properties/SeataProperties.java 35.55% <0.00%> (-5.48%) ⬇️
...ing/boot/autoconfigure/SeataAutoConfiguration.java 0.00% <0.00%> (ø)
...ta/spring/annotation/GlobalTransactionScanner.java 30.65% <0.00%> (ø)
...va/io/seata/server/console/vo/GlobalSessionVO.java 22.05% <0.00%> (-33.83%) ⬇️
... and 13 more

@lgtm-com
Copy link

lgtm-com bot commented May 5, 2022

This pull request fixes 1 alert when merging df2088d into 8c350b0 - view on LGTM.com

fixed alerts:

  • 1 for Use of a broken or risky cryptographic algorithm

@slievrly slievrly changed the title optimize:use HmacSHA256 instead of HmacSHA1 for ram signature optimize: use HmacSHA256 instead of HmacSHA1 for ram signature May 5, 2022
@slievrly slievrly merged commit 8a12ddc into apache:develop May 5, 2022
@slievrly slievrly added this to the 1.5.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants