optimize: check relation of before status and after status when updating global session

server/src/main/java/io/seata/server/session/SessionHelper.java

@@ -202,13 +202,67 @@ public static void endRollbackFailed(GlobalSession globalSession, boolean retryG
         MetricsPublisher.postSessionDoneEvent(globalSession, retryGlobal, false);
     }
 
+    /**
+     * is timeout global status timeout
+     *
+     * @param status the global session
+     */
     public static boolean isTimeoutGlobalStatus(GlobalStatus status) {
         return status == GlobalStatus.TimeoutRollbacked
                 || status == GlobalStatus.TimeoutRollbackFailed
                 || status == GlobalStatus.TimeoutRollbacking
                 || status == GlobalStatus.TimeoutRollbackRetrying;
     }
 
+    /**
+     * is rollback global status timeout
+     *
+     * @param status the global session
+     */
+    public static boolean isRollbackGlobalStatus(GlobalStatus status) {
+        return status == GlobalStatus.Rollbacking
+                || status == GlobalStatus.RollbackRetrying
+                || status == GlobalStatus.Rollbacked
+                || status == GlobalStatus.RollbackFailed
+                || status == GlobalStatus.RollbackRetryTimeout;
+    }
+
+    /**
+     * is commit global status timeout
+     *
+     * @param status the global session
+     */
+    public static boolean isCommitGlobalStatus(GlobalStatus status) {
+        return status == GlobalStatus.Committing
+                || status == GlobalStatus.AsyncCommitting
+                || status == GlobalStatus.CommitRetrying
+                || status == GlobalStatus.Committed
+                || status == GlobalStatus.CommitFailed
+                || status == GlobalStatus.CommitRetryTimeout;
+    }
+
+    /**
+     * check the relation of before status and after status
+     *
+     * @param before the global session
+     * @param after the global session
+     */
+    public static boolean validateUpdateStatus(GlobalStatus before, GlobalStatus after) {
+        if (isTimeoutGlobalStatus(before) && isCommitGlobalStatus(after)) {
+            return false;
+        }
+        if (isCommitGlobalStatus(before) && isTimeoutGlobalStatus(after)) {
+            return false;
+        }
+        if (isRollbackGlobalStatus(before) && isCommitGlobalStatus(after)) {
+            return false;
+        }
+        if (isCommitGlobalStatus(before) && isRollbackGlobalStatus(after)) {
+            return false;
+        }
+        return true;
+    }
+
     /**
      * Foreach global sessions.
      *

server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java

@@ -28,6 +28,7 @@
 import java.util.stream.Collectors;
 import io.seata.config.Configuration;
 import io.seata.config.ConfigurationFactory;
+import io.seata.server.session.SessionHelper;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import com.google.common.collect.ImmutableMap;
@@ -326,6 +327,10 @@ private boolean updateGlobalTransactionDO(GlobalTransactionDO globalTransactionD
                 jedis.unwatch();
                 return true;
             }
+            if (SessionHelper.validateUpdateStatus(GlobalStatus.get(Integer.parseInt(previousStatus)),
+                GlobalStatus.get(globalTransactionDO.getStatus()))) {
+                throw new StoreException("illegal changing of global status, update global transaction failed.");
+            }
 
             String previousGmtModified = statusAndGmtModified.get(1);
             Transaction multi = jedis.multi();