optimize: check relation of before status and after status when updating global session #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengten
reviewed
May 23, 2022
server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java
Show resolved
Hide resolved
funky-eyes
reviewed
May 23, 2022
server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java
Outdated
Show resolved
Hide resolved
|
This pull request introduces 1 alert when merging cb80631 into 09832bd - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #4629 +/- ##
=============================================
- Coverage 49.03% 49.03% -0.01%
- Complexity 4056 4067 +11
=============================================
Files 734 735 +1
Lines 25577 25594 +17
Branches 3156 3160 +4
=============================================
+ Hits 12542 12549 +7
- Misses 11699 11705 +6
- Partials 1336 1340 +4
|
funky-eyes
reviewed
May 25, 2022
server/src/test/java/io/seata/server/session/SessionStatusValidatorTest.java
Show resolved
Hide resolved
caohdgege
reviewed
Jun 9, 2022
server/src/main/java/io/seata/server/session/SessionStatusValidator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/session/SessionStatusValidator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java
Outdated
Show resolved
Hide resolved
|
标题是 |
Bughue
changed the title
caohdgege
changed the title
slievrly
reviewed
Jun 10, 2022
| * @param before the global session | ||
| * @param after the global session | ||
| */ | ||
| public static boolean validateUpdateStatus(GlobalStatus before, GlobalStatus after) { |
There was a problem hiding this comment.
A state flow control can be designed.
There was a problem hiding this comment.
A state flow control can be designed.
to prevent too many state updates at the same time?
liuqiufeng
pushed a commit
to liuqiufeng/seata
that referenced
this pull request
Jun 11, 2022
…ing global session (apache#4629)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
redis模式下，检查全局事务状态的转变关系，以下四种方向不允许
rollback（进行中或结束）>> commit（进行中或结束）
commit（进行中或结束）>> rollback（进行中或结束）
timeout（进行中或结束）>> commit（进行中或结束）
commit（进行中或结束）>> timeout（进行中或结束）
Ⅱ. Does this pull request fix one issue?
#4372
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews