Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix in high version springboot property not resolved #4817

Merged
merged 4 commits into from Jul 28, 2022

Conversation

liujunlin5168
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

bugfix: fix in high version springboot property not Standard

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the base branch from 1.5.2 to develop July 27, 2022 10:43
@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2022

This pull request introduces 1 alert when merging a111954 into 46d75f3 - view on LGTM.com

new alerts:

  • 1 for Race condition in double-checked locking object initialization

@codecov-commenter
Copy link

Codecov Report

Merging #4817 (7fc11ef) into develop (15add9a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4817   +/-   ##
==========================================
  Coverage      49.21%   49.21%           
- Complexity      4091     4092    +1     
==========================================
  Files            736      736           
  Lines          25723    25723           
  Branches        3177     3177           
==========================================
  Hits           12659    12659           
  Misses         11715    11715           
  Partials        1349     1349           
Impacted Files Coverage Δ
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @wangliang181230 PTAL

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. first-time contributor first-time contributor module/seata-spring-boot-starter seata-spring-boot-starter module labels Jul 27, 2022
@funky-eyes funky-eyes added this to the 1.6.0 milestone Jul 27, 2022
@slievrly
Copy link
Member

#4801

@slievrly
Copy link
Member

@liujunlin5168 Pls indicate the starting springboot version.

@slievrly slievrly changed the title bugfix: fix in high version springboot property not Standard bugfix: fix in high version springboot property not resolved Jul 27, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit b42f8d0 into apache:develop Jul 28, 2022
conghuhu pushed a commit to conghuhu/seata that referenced this pull request Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/seata-spring-boot-starter seata-spring-boot-starter module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants