bugfix: mysql insert on update duplicate sensitive case not matched #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
type: bug
Codecov Report
@@ Coverage Diff @@
## develop #4912 +/- ##
=============================================
+ Coverage 49.03% 49.04% +0.01%
- Complexity 4087 4088 +1
=============================================
Files 736 736
Lines 25784 25785 +1
Branches 3180 3180
=============================================
+ Hits 12642 12646 +4
+ Misses 11799 11798 -1
+ Partials 1343 1341 -2
|
funky-eyes
changed the title
|
This pull request introduces 1 alert when merging bdb6ee6 into 8ec5ccd - view on LGTM.com new alerts:
|
slievrly
reviewed
Sep 6, 2022
rm-datasource/src/main/java/io/seata/rm/datasource/exec/mysql/MySQLInsertOrUpdateExecutor.java
Show resolved
Hide resolved
|
This pull request introduces 1 alert when merging f9f9550 into b5ddb71 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 6de7b0f into b5ddb71 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 87554b6 into b5ddb71 - view on LGTM.com new alerts:
|
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… matched
Ⅰ. Describe what this PR did
当数据库column为大写，而sql为小写时，读取parameter时匹配不上，造成了前镜像的sql为select * from table导致了全表扫描，后镜像也进行了一次全表扫描的bug
Ⅱ. Does this pull request fix one issue?
fixes #4909
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews