bugfix: insert value is all parsed as string in insert on duplicate #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
changed the title
funky-eyes
reviewed
Oct 31, 2022
| @@ -263,7 +264,7 @@ public TableRecords buildTableRecords2(TableMeta tableMeta, String selectSQL, Ar | |||
| for (int i = 0; i < ts; i++) { | |||
| List<Object> paramAppender = paramAppenderList.get(i); | |||
| for (int j = 0; j < ds; j++) { | |||
| ps.setObject(i * ds + j + 1, "NULL".equals(paramAppender.get(j).toString()) ? null : paramAppender.get(j)); | |||
| ps.setObject(i * ds + j + 1, (paramAppender.get(j) instanceof Null) ? null : paramAppender.get(j)); | |||
There was a problem hiding this comment.
get(j)优化下，没必要get2次，虽然很快
Codecov Report
@@ Coverage Diff @@
## develop #5028 +/- ##
=============================================
+ Coverage 49.03% 49.32% +0.29%
- Complexity 4090 4119 +29
=============================================
Files 733 733
Lines 26012 26012
Branches 3213 3213
=============================================
+ Hits 12755 12831 +76
+ Misses 11895 11818 -77
- Partials 1362 1363 +1
|
funky-eyes
changed the title
zw201913
pushed a commit
to zw201913/seata
that referenced
this pull request
Nov 7, 2022
* '1103' of https://github.com/zw201913/seata: optimize: remove useless code (apache#5047) bugfix: fix startup failure of Server1.5.2 by using OpenJDK 11 (apache#4874) bugfix: insert value is all parsed as string in insert on duplicate (apache#5028) bugfix: global session is not change to Committed in saga mode (apache#5050)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecutor
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5023
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews