-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy the dependency #981
Tidy the dependency #981
Conversation
2、Remove guava ,use [caffine](https://github.com/ben-manes/caffeine) to instead of guava cache 3、Remove other useless jars 4、Upgrade junit4 to [junit5](https://junit.org/junit5/docs/current/user-guide) 5、Remove testng
Codecov Report
@@ Coverage Diff @@
## develop #981 +/- ##
=============================================
+ Coverage 36.97% 38.34% +1.36%
- Complexity 1033 1046 +13
=============================================
Files 225 219 -6
Lines 8908 8714 -194
Branches 1080 1085 +5
=============================================
+ Hits 3294 3341 +47
+ Misses 5212 4951 -261
- Partials 402 422 +20
Continue to review full report at Codecov.
|
Suggestion:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Done in a9a09ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some conflict files.
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job,but I have some confusion,why delete seata-* in dependencyManagement, and each module has a <version>${project.version}</version>
in other pom?
I think the version of dependecies we put in the dependencyManagement is changeable, but the version of submodule dependency is fixed, we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tidy the maven dependency * 1、Unify the version of `netty` * 2、Use [caffine](https://github.com/ben-manes/caffeine) to instead of guava cache * 3、Upgrade junit4 to [junit5](https://junit.org/junit5/docs/current/user-guide) * 4、Remove testng (use [junit5](https://junit.org/junit5/docs/current/user-guide))
Ⅰ. Describe what this PR did
tidy the maven dependency
Ⅱ. Does this pull request fix one issue?
#933
Ⅲ. Why don't you add test cases (unit test/integration test)?
Config change
Ⅳ. Describe how to verify it
ci pass
Ⅴ. Special notes for reviews
1、Unify the version of
netty
2、Remove guava ,use caffine to replace guava cache
3、Remove other useless jars
4、Upgrade junit4 to junit5
5、Remove testng (use junit5 )