[Improve] Unified logging standards.

apache · May 23, 2024 · ecb25e3 · ecb25e3
1 parent e35ec93
commit ecb25e3
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 9 deletions.
diff --git a/...console-service/src/main/java/org/apache/streampark/console/core/entity/FlinkCluster.java b/...console-service/src/main/java/org/apache/streampark/console/core/entity/FlinkCluster.java
@@ -168,7 +168,7 @@ public boolean verifyClusterConnection() {
         JacksonUtils.read(result, Overview.class);
         return true;
       } catch (Exception e) {
-        log.error("verify cluster {} connection failed!", address, e);
+        log.error("Verify cluster {} connection failed!", address, e);
       }
       return false;
     } else if (ExecutionMode.YARN_SESSION.equals(this.getExecutionModeEnum())) {
@@ -180,7 +180,7 @@ public boolean verifyClusterConnection() {
         JacksonUtils.read(result, Overview.class);
         return true;
       } catch (Exception e) {
-        log.error("verify cluster connection failed!", e);
+        log.error("Verify cluster connection failed!", e);
       }
       return false;
     }

diff --git a/...in/java/org/apache/streampark/console/core/service/impl/ApplicationBackUpServiceImpl.java b/...in/java/org/apache/streampark/console/core/service/impl/ApplicationBackUpServiceImpl.java
@@ -199,7 +199,7 @@ public Boolean delete(Long id) throws InternalException {
       removeById(id);
       return true;
     } catch (Exception e) {
-      log.error("delete application {} failed!", id, e);
+      log.error("Delete application {} failed!", id, e);
       throw new InternalException(e.getMessage());
     }
   }

diff --git a/...src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java b/...src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java
@@ -332,7 +332,7 @@ public String upload(MultipartFile file) throws Exception {
     try {
       file.transferTo(saveFile);
     } catch (Exception e) {
-      log.error("upload file {} failed!", fileName, e);
+      log.error("Upload file {} failed!", fileName, e);
       throw new ApiDetailException(e);
     }
     return saveFile.getAbsolutePath();
@@ -496,7 +496,7 @@ private void removeApp(Application application) {
         HdfsOperator.delete(path);
       }
     } catch (Exception e) {
-      log.error(Utils.stringifyException(e));
+      log.error("Remove application {} failed!", appId, e);
     }
   }
 
@@ -807,7 +807,7 @@ public boolean create(Application appParam) {
       }
       return true;
     } else {
-      log.error("create application failed");
+      log.error("Create application failed!");
       throw new ApiAlertException("create application failed");
     }
   }
@@ -1846,7 +1846,7 @@ private void doStopped(Application appParam) {
           yarnClient.killApplication(applications.get(0).getApplicationId());
         }
       } catch (Exception e) {
-        log.error("doStopped failed!", e);
+        log.error("Stopped failed!", e);
       }
     }
   }

diff --git a/...ice/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java b/...ice/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
@@ -327,6 +327,7 @@ public List<Map<String, Object>> listConf(Project project) {
       }
       return list;
     } catch (Exception e) {
+      log.error("List conf Failed!", e);
       log.error(e.getMessage());
     }
     return null;

diff --git a/...e/src/main/java/org/apache/streampark/console/core/service/impl/SavePointServiceImpl.java b/...e/src/main/java/org/apache/streampark/console/core/service/impl/SavePointServiceImpl.java
@@ -430,7 +430,7 @@ public Boolean delete(Long id, Application application) throws InternalException
       removeById(id);
       return true;
     } catch (Exception e) {
-      log.error("delete application :{} failed!", id, e);
+      log.error("Delete application {} failed!", id, e);
       throw new InternalException(e.getMessage());
     }
   }

diff --git a/...ice/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java b/...ice/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java
@@ -91,7 +91,7 @@ public boolean update(Setting setting) {
       optional.ifPresent(x -> x.setSettingValue(value));
       return true;
     } catch (Exception e) {
-      log.error("update setting failed!", e);
+      log.error("Update setting failed!", e);
       return false;
     }
   }